> > On Wed, Jun 17, 2015 at 10:30 AM, James Swaro <james.sw...@gmail.com> > wrote: > >> If I understand the patch correctly, it would only cause problems for >> connections with over 2GB of data payload, but I think it should work fine >> for a small trace of say 200KB. I'm not seeing any events at all, nor am I >> seeing the log files that should be created when using the analyzer. >> > > That was the point of that change, yes, but the breaking modification was > that the function signatures are now different. Specifically, those are > virtual functions that you're inheriting. If your parameters don't match > exactly, you're just defining a new virtual function as opposed to > redefining the existing function. >
Good point. > > >> I'll correct the functions and test it out though. >> > > When you said that you're not seeing DeliverPacket be entered, was that > after making the uint64 change? > I thought I had corrected it, but seems like the definition was still slightly off. I'm getting all of my logs now as expected. Thanks. On Wed, Jun 17, 2015 at 7:13 PM, Vlad Grigorescu <v...@grigorescu.org> wrote: > On Wed, Jun 17, 2015 at 10:30 AM, James Swaro <james.sw...@gmail.com> > wrote: > >> If I understand the patch correctly, it would only cause problems for >> connections with over 2GB of data payload, but I think it should work fine >> for a small trace of say 200KB. I'm not seeing any events at all, nor am I >> seeing the log files that should be created when using the analyzer. >> > > That was the point of that change, yes, but the breaking modification was > that the function signatures are now different. Specifically, those are > virtual functions that you're inheriting. If your parameters don't match > exactly, you're just defining a new virtual function as opposed to > redefining the existing function. > > >> I'll correct the functions and test it out though. >> > > When you said that you're not seeing DeliverPacket be entered, was that > after making the uint64 change? > > --Vlad > > -- James Swaro
_______________________________________________ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
