On Tue, Aug 7, 2018 at 5:15 PM Jim Mellander <jmellan...@lbl.gov> wrote:

> Incidentally, I think theres a bug in the observe() function:
>
> These two lines are run in the loop thru the reducers:
>                if ( r?$normalize_key )
>                         key = r$normalize_key(copy(key));
> which has the effect of modifying the key for subsequent loops, rather than 
> just for the one reducer it applies to.  The fix is easy and and obvious....

Yeah, looked wrong to me also.  Fixed via [1] in master branch now.
Sorry I don't have much knowledge of the existing sumstats code to
drive the other discussion/suggestions forward.

- Jon

https://github.com/bro/bro/commit/5821c16490e731a68c0efc9c1aaba2d7aec28f48
_______________________________________________
bro-dev mailing list
bro-dev@bro.org
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev

Reply via email to