> > I mean that "ipmpstat -P" is an error without also specifying "-o". This
> > is similar to "-P" with "-o all" being an erorr, but should be a distinct
> > error because we'd like a distinct error message.
>
> Yes, but I am already catching that as a null str passed to ofmt_open().
> since the convention is that not specifying "-o" implies "-o all".
That's incorrect: "-o all" means "display all fields", whereas not
specifying "-o" means "display only the fields that will fit in 80
columns"; try "ipmpstat -p -o all" ("-p" as in probe mode, not parsable
mode) vs. "ipmpstat -p". This is an important distinction that the
output engine needs to get right.
> > In any case, this API is consolidation-private for now so we can always
> > change this (though it is tedious to update all the callers).
>
> so I've gone with the simpler boolean return model here.
OK.
> > > anyway, latest (final?) webrevs are available in the usual
> >
> > Given that I've only reviewed two files (ofmt.c and ipmpstat.c) and I've
> > seen very few comments on the other files, I'm surprised this is being
> > considered a possible final webrev.
>
> I don't think you are suggesting that this is inadequately reviewed,
> but, fyi, Mike Lim and Seb sent me comments separately. You're also
> welcome to review the other files, if you like. As I mentioned, both
> webrev and webrev.meem have been updated.
Unfortunately I don't have the time to review dladm.c and flowadm.c. From
the comments I saw, it was not clear that they had signed off on those
files. I still plan to review ofmt.h and the Makefiles and packaging.
I also still owe you a new comment for ipmpstat.c.
--
meem
