On (04/01/09 18:44), Girish Moodalbail wrote:
>
> /net/trigati.east/export/build/gm209912/possible_mtu
>

- suggest MAC_PROP_MTU_RANGE instead of MAC_PROP_SUPPORTED_MTU_RANGE

- libdladm: suggest renaming i_dladm_uint32_range_get to i_dladm_mtu_range_get
  since this function is very specific to mtu.

- what value would be printed for other drivers like afe, mxfe etc? 
  I believe these would return ENOTSUP- so would you print "--"? that does
  not sound correct- it is intuitively misleading to print a non-zero
  value in "current" but print "--" in POSSIBLE.  Note that,
  in conjunction with CR 6787179, the mac layer can itself return both 
  the min and max for the drivers that do not have a writable-mtu, by
  extracting the information in the registered max_sdu. Of course, libdladm
  can also do the same thing in a much clumsier way, but printing CURRENT
  value when the POSSIBLE is "--"

--Sowmini


Reply via email to