On 05/05/09 12:46, Sowmini.Varadhan at Sun.COM wrote:
> Mike,
>
> Erik and I were talking about having multiple -p
> flags to our *adm commands, and Erik pointed out
> that this may not be a good idea because it complicates
> error-cases. e.g., if I do
>
>   dladm set-linkprop -p p1=v1 -p badprop=badval -p p3=v3 link0
>
> and "p1=v1" and "p3=v3" are syntactically correct,
> what is the error code ($?) returned to the shell after your
> fix for 6601421? And if $? is non-zero, are p1 and p3 set to v1 and v3?
>
> Note that Girish and I tried this with zfs.. it would set as much
> as it can, and also return an error code, which is confusing.
>   
This problem pre-dates the change I made to accept
multiple "-p" options.  It started with the acceptance of
multiple properties in a single "-p" instance.

#dladm set-linkprop -p p1=v1 -p badprop=badval link0

is the same as

#dladm set-linkprop -p p1=v1,badprop=badval link0

-Mike

Reply via email to