Hola, I just completed the conversion to brussels properties for my driver. While doing this, I collected some suggestions below. Let me start by saying that dladm linkprops are a step forward in ease of administration.
Regards, Joost There are 2 sets of properties named MAC_PROP_ADV_ and MAC_PROP_EN_. There is a 3rd set, the defaults, that is implemented as a bit named MAC_PROP_DEFAULT in pr_flags. It was unclear to me for which properties defaults are actually retrieved. It might be cleaner to spell out all properties for which defaults are required as MAC_PROP_DEFAULT_. When adv_autoneg_cap is 0, a link's speed and duplex should be writable properties. Currently, these are readonly, which results in funny implementations. e1000g for example, selects the "best" speed and duplex from the enabled set (MAC_PROP_EN_*_CAP) when autoneg is turned off. I found this confusing. IMHO, it would be better to have speed duplex readonly when autoneg is on and writable when autoneg is off. The -p option for dladm's set-linkprop and show-linkprop doesn't add value for me. Today, dladm's syntax is "dladm command -p prop=val link". I think it would easier to just have "dladm command prop=val link". Especially because -p is used elsewhere in dladm for producing parseable output. There is a property called adv_autoneg_cap. I think it's cleaner to rename this one to "autoneg" or "linknegotiation". There's no such thing as an advertised autoneg capability. -- Joost Mulders + email: joost.mulders at sun.com Technical Specialist + phone: +31-33-45-15701 Client Solutions + fax: +31-33-45-15734 Sun Microsystems + mobile: +31-6-5198-7268 -= Anything not done right, has to be done again =- -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/brussels-dev/attachments/20080912/3d5feaff/attachment.html>
