Sowmini.Varadhan at Sun.COM wrote:
> On (05/13/08 16:30), Garrett D'Amore wrote:
>
>> Webrev is at http://cr.opensolaris.org/~gdamore/afe-mxfe-brussels/
>>
>>
>
> Changes look good, but do these drivers not support mtu?
No, standard ethernet MTU support only. I suppose I could support
*reducing* the MTU, but to what end? (I could allow for increasing the
MTU slightly -- but the maximum MTU size would be 2047, so its of very
limited use.)
> What
> about flowctrl?
>
The hardware can do it, but I never added support to the drivers.
> The only other minor nit is that instead of using so many uint8_t's,
> for the MII props (most of which are 0/1), you could have used
> bits in a uint32_t. But that's a nit that I'll let you use
> your judgement on.
>
Bit fields have other issues -- you can't make accesses atomic, for
one. I'm not too worried about saving a few bytes. :-)
-- Garrett
> --Sowmini
>
>
