Anurag S. Maskey wrote:
> Sure, I'll wait for your changes to be putback and then change those
> two drivers as well.
>
> As for vnet.h, modhash does not get included for vnet_dds.c.
> Originally, mac.h included dld.h, which ultimately included modhash.h
> for vnet.h. Now, with the changes, mac.h does not include dld.h and
> thus, the need to include modhash.h in vnet.h.
Okay, seems reasonable to me. I've asked my RTI advocate (Seth
Goldberg) to review the RTI today. Hopefully I'll put back the changes
later today. If anyone is reading this and thinks they'd be a better
advocate, please let me know.
-- Garrett
>
> Anurag
>
> Garrett D'Amore wrote:
>> So, why the change in vnet.h to #include modhash?
>>
>> The other changes look fine to me. (If my afe/mxfe RTI is accepted
>> before this code, you'll need to update those two drivers as well.
>> It depends on who gets in first, though. As my RTI has already been
>> submitted, I'd appreciate it if you could wait and fix those two as
>> well.)
>>
>> -- Garrett
>>
>> Anurag S. Maskey wrote:
>>> Hi all,
>>>
>>> I've fixed this bug (RFE) "6674402 sort out property management
>>> related constants and data-structures in {dld,mac}.h" and would like
>>> a code-review.
>>>
>>> Miles, can you also get a sign-off for the NVIDIA driver?
>>> Since this is my first bug fix, I would appreciate if this code
>>> review can be done in one to two weeks?
>>>
>>> The webrev is at http://cr.opensolaris.org/~sowmini/anurag/.
>>>
>>> Fixing this RFE involved renaming constants and variables with "dld"
>>> to "mac" and also moving the definition of these constants from
>>> /usr/src/uts/common/sys/dld.h to /usr/src/uts/common/sys/mac.h. Also,
>>> the following drivers include sys/mac.h rather than sys/dld.h: dld,
>>> mac, bge, e1000g, nge, nxge.
>>>
>>> The following shows how the renaming was done:
>>>
>>> OLD_NAME NEW_NAME
>>>
>>> dld_prop_id_t mac_prop_id_t
>>> dld_ioc_prop_t dld_ioc_macprop_t
>>> DLD_PROBUF_SIZE MAC_PROPBUF_SIZE
>>> DLD_PROP_DUPLEX MAC_PROP_DUPLEX
>>> DLD_PROP_SPEED MAC_PROP_SPEED
>>> DLD_PROP_STATUS MAC_PROP_STATUS
>>> DLD_PROP_AUTONEG MAC_PROP_AUTONEG
>>> DLD_PROP_MTU MAC_PROP_MTU
>>> DLD_PROP_FLOWCTRL MAC_PROP_FLOWCTRL
>>> DLD_PROP_VERSION MAC_PROP_VERSION
>>> DLD_PROP_ADV_1000FDX_CAP MAC_PROP_ADV_1000FDX_CAP
>>> DLD_PROP_EN_1000FDX_CAP MAC_PROP_EN_1000FDX_CAP
>>> DLD_PROP_ADV_1000HDX_CAP MAC_PROP_ADV_1000HDX_CAP
>>> DLD_PROP_EN_1000HDX_CAP MAC_PROP_EN_1000HDX_CAP
>>> DLD_PROP_ADV_100FDX_CAP MAC_PROP_ADV_1000FDX_CAP
>>> DLD_PROP_EN_100FDX_CAP MAC_PROP_EN_1000FDX_CAP
>>> DLD_PROP_ADV_100HDX_CAP MAC_PROP_ADV_1000HDX_CAP
>>> DLD_PROP_EN_100HDX_CAP MAC_PROP_EN_1000HDX_CAP
>>> DLD_PROP_ADV_10FDX_CAP MAC_PROP_ADV_1000FDX_CAP
>>> DLD_PROP_EN_10FDX_CAP MAC_PROP_EN_1000FDX_CAP
>>> DLD_PROP_ADV_10HDX_CAP MAC_PROP_ADV_1000HDX_CAP
>>> DLD_PROP_EN_10HDX_CAP MAC_PROP_EN_1000HDX_CAP
>>> DLD_PROP_PRIVATE MAC_PROP_PRIVATE
>>> DLD_DEFAULT MACPROP_DEFAULT
>>> DLD_PROP_ADV_100T4_CAP MAC_PROP_ADV_100T4_CAP
>>> DLD_PROP_EN_100T4_CAP MAC_PROP_EN_100T4_CA
>>> DLDIOCSETPROP DLDIOCSETMACPROP
>>> DLDIOCGETPROP DLDIOCGETMACPROP
>>> dld_ioc_prop_s dld_ioc_macprop_s
>>> DLD_PROP_VERSION MAC_PROP_VERSION
>>>
>>> Thanks,
>>> Anurag
>>>
>>> _______________________________________________
>>> brussels-dev mailing list
>>> brussels-dev at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/brussels-dev
>>>
>>
