Sowmini.Varadhan at Sun.COM wrote: > On (03/19/08 14:10), Garrett D'Amore wrote: > >> Are those "well-known" properties? (I.e. do more drivers than just bge >> make use of those names?) If so, then you should just remap it in the >> > > it's not uniformly supported across drivers. And the > lack of uniformity was the reason PSARC 2007/429 came up > with flowctrl. >
Yeah, I recall that. How hard would it be to just silently convert these outliers (there can't be too many of them) to the equivalent well-known properties? > But there are other outliers.. nge, for example has a bunch of > parameters for bcopy/dma thresholds. Yes, these should > be auto-tuned, but they are not, and until they are auto-tuned, > we need some way to control them. > Yes, and we have that via dladm. I don't think we need access via NDD. > >> So, in retrospect (I think I suggested this earlier), I'd actually >> welcome a change that did: >> >> 1) offered only well-known names via NDD >> 2) make all other private properties only available via dladm >> > > If we are going to do this, then we may as well skip all > of the ndd compat effort, as Joost suggested. > Maybe. I still think there is significant value in supporting MII for ndd, at least until the various consumers of ndd have been converted. SunVTS comes to mind, and I'm sure there are customer scripts as well. But all those consumers are consumers of "well-known" properties (MII stuff), so if we did a "limited" amount of NDD support, I think it would be fine. > >> 3) as a consequence of #1 above, you could actually skip the separate >> registration of property names for now, until another consumer of them >> (dladm?) exists >> >> Something to think about, at least. >> >> > > I think there is some value in having mac_register_private_prop > interfaces. > I do too. I'm just not sure that NDD is the best case for them. I think dladm needs to grow some ability to inquire about tunables (ala the '?' arg to ndd), but that is a topic for future consideration. If you could defer the mac_register_private_prop() (and maybe then look at table-based registration, etc.) until later, it may simplify your life right now. -- Garrett
