On Mon, 2008-06-23 at 13:14 -0700, Artem Kachitchkine wrote:
> > So, this should be false only for WiFi links? If that's the case, then
> > these calls look wrong:
> >
> > libdlaggr.c: (void) dladm_init_linkprop(linkid, B_FALSE);
> > libdlvlan.c: (void) dladm_init_linkprop(vlanid, B_FALSE);
> >
> > Should this be true or false for IP tunnel links?
>
> If you know that your link is not a wifi link, you do not need to call
> dladm_init_linkprop() at all.
Okay, but how do the link properties for my tunnel links get loaded at
boot if there's no call to dladm_init_linkprop() in the up-iptun code?
I think this is just a matter of my getting familiar with your new code.
> Otherwise pass B_FALSE.
> When wifi property
> ioctls are converted to DLD...SETPROP, all calls to
> dladm_init_linkprop() outside of dlmgmtd will be removed.
>
> Calls in libdl{aggr,vlan}.c are probably already redundant if they only
> apply to non-wifi links - they will do nothing, which is the correct
> behavior.
Aggregations and VLANs are not physical WiFi links.
Thanks,
-Seb
