I'll include Sowmini's comments, plus any others that happen to drift in over the next couple of days.
Terry > X-Authentication-Warning: quasimodo.East.Sun.COM: sowmini set sender to sowmini.varadhan at sun.com using -f > To: Sebastien Roy <Sebastien.Roy at sun.com> > Cc: clearview-discuss <clearview-discuss at opensolaris.org>, Terry.Gibson at sun.com, brussels-dev at opensolaris.org > Subject: Re: [clearview-discuss] review for merged UV/Brussels dladm(1M) man page > MIME-Version: 1.0 > Content-Disposition: inline > User-Agent: Mutt/1.5.16 (2007-06-11) > > On (01/15/08 16:09), Sebastien Roy wrote: > > > > Here it is, it its full glory: > > > > thanks for going through this exercise! This looks very good. some > comments: > > > > dladm show-ether [-p] [-o field,...] [name] > > should be > > dladm show-ether [-px] [-o field,...] [name] > > Also, some corrections to the strings printed out for: > > > PAUSE Flow control information. Can be "" > > (null string) indicating no flow > > control is available, tx indicating > > that the end-point can transmit > > pause frames, but ignores any > > received pause frames, rx indicating > > that the end-point receives and acts > > upon received pause frames, or both > > indicating bi-directional flow- > > control. > > These should be > > PAUSE Flow control information. Can be "no" > indicating no flow control is > available, "tx" indicating > that the end-point can transmit > pause frames, but ignores any > received pause frames, "rx" indicating > that the end-point receives and acts > upon received pause frames, or "bi" > indicating bi-directional flow- > control. > > > > General Link Property > > should be "Properties", and include autopush here? > > > The following general link property is supported: > : > > Ethernet Link Properties > > The following MII Properties as documented in ieee802.3(5) > > are supported in read-only mode: > : > > Each adv_ property (for example, adv_autoneg_cap) also has a > > read/write counterpart enable_ property (for example, > > enable_autoneg_cap) controlling parameters used at > > autonegotiation. > > s/enable/en, i.e., the prefix should be en_ so that this is > > > "Each adv_ property (for example, adv_100fdx_cap) also has a > read/write counterpart en_ property (for example, > en_100fdx_cap) controlling parameters used at > autonegotiation." > > > SEE ALSO > > ifconfig(1M), zonecfg(1M), wpad(1M), attributes(5), dlpi(7P) > > add ieee802.3(5) and ndd(1M) here. > > --Sowmini >
