On (01/28/08 13:11), Sowmini.Varadhan at Sun.COM wrote:
> >
> > As does dropping the redundant and ugly "default_" part of the name.
> > Speaking of redundant, I also can't fathom why we have "link_duplex"
> > instead of just "duplex", and a link_up property that takes "up" and
> > "down" as values instead of "yes" and "no".
> >
> > Would the Brussels team support a fasttrack cleaning up these names a bit?
>
> sure.. do you want to summarize the name changes on the list to get
> this rolling?
Ok, here's a draft (thanks Seb for the preliminary review):
--Sowmini
-----------------------------------------------------------------------
1. Summary
This case comprises modifications and cleanup to interfaces
presented in PSARC 2007/429.
2. Details
2.1 Updates to struct dld_ioc_prop_s
The dld_ioc_prop_s structure is used to pass data between
user and kernel space as part of the DLDIOCSETPROP and
DLDIOCGETPROP ioctl. This structure, as defined in
PSARC 2007/429, contains the name of the link in the
pr_linkname field.
This fast-track changes that field to contain a datalink_id_t
value introduced as part of PSARC 2006/499 (Clearview Nemo
unification and vanity naming). Thus the new structure shall be:
typedef struct dld_ioc_prop_s {
int pr_version;
uint_t pr_flags;
datalink_id_t pr_linkid;
dld_prop_id_t pr_num;
char pr_name[DLD_LINKPROP_NAME_MAX];
uint_t pr_valsize;
char pr_val[1];
} dld_ioc_prop_t;
2.2 Changes to Exported interfaces:
This fast-track updates the names of the following parameters.
Note that the Classification of the interface is not modified
by this Fast-track.
2007/429 Proposed
interface interface
name name
--------------------------------
ifspeed speed
link_duplex duplex
default_mtu mtu
link_up state
