On (09/24/07 14:06), Artem Kachitchkine wrote: > > > > http://cr.opensolaris.org/~artem/bru-prophandle/ > > > - addressed Sowmini's comments: > - locking in mac_prop_update() > - mac_setprop() updates cache only when mc_setprop callback succeeds > - ipw includes <net/if.h> directly > - added mdb mac module with two walkers and ::mac_prop dcmd
I really like the mdb commands! Even without the libdladm helpers (which I personally think are not needed in this case- the complexity of pulling that in is probably not worth the benefits in this case) this is much better than the current state of affairs. Changes look good. Just one minor nit (and I realized after review that I have more instances of this, and related size checks, in my own arcfixes webrev): mac_prop_load: use LIFNAMSIZ for macname[] Please putback (and also review my webrev later) --Sowmini
