Sowmini.Varadhan at Sun.COM writes:
> I've placed tentative [#] copies of PSARC commitment materials
> for 2007/429 at
>
> http://cr.opensolaris.org/~sowmini/commitment.materials/
A level-0 question first: what's changed?
It's usually helpful to provide some sort of overview of what you've
changed since the last ARC review. Two common ways of doing that are
to take the issues file and interleave the questions with the answers,
and providing an overview document that points out the areas that have
been updated. Marking up documents with change bars or similar is
also sometimes done.
It's not a requirement, but I suspect that it'll be the first question
you get on commitment, and getting it out of the way sooner would be
better.
Remaining comments:
- How are adv_*_cap Volatile? What will change here? (Does this
actually mean Obsolete or something else?)
- Loopback ioctls?
- Will use of ndd for drivers eventually go away? Is that part of
the plan or will we carry compatibility forever?
- Nit: strncmp on page 20 of brussles.pdf is quite odd. I don't
think this does what you're expecting it does. (Notably, strcmp
would be just as safe, because "_drain_max" is a fixed-length
string with a terminating NUL byte.)
--
James Carlson, Solaris Networking <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
