sowmini.varadhan at sun.com wrote:
> After spending some time processing all the input from the
> discussion about show-linkprop enhancements, here's a summary:
>
> (a) dladm show-linkprop will be the complement dladm set-linkprop.
>
> Thus, if we want to set a property "ugly_property_name" by doing
>
> # dladm set-linkprop -p ugly_property_name=<value> <link>
>
> then the output of "show-linkprop" would look like
>
> PROPERTY VALUE DEFAULT POSSIBLE
> :
> ugly_property_name <value> ...
> :
>
> An important point to note is that, since show-linkprop is
> intended to only be the complement of set-linkprop, it will only
> display the r/w properties (see (c) below for finding the read-only
> properties).
>
I'm not entirely sure I agree with that last point. But I'm willing to
concede it, if there is some value perceived in displaying less than the
full set of properties here.
> (b) ugly property names/semantics should be avoided where possible.
> e.g., the pause/asympause definitions that exist in MII today, where
> the current truth table in ieee802.3(5) is, mildly put,
> confusing. [We are looking into providing alternative, simpler
> definitions for pause/asympause- details coming soon].
>
Simple recommendation:
* Allow for tristate values:
cap_pause = both, tx, rx
adv_pause = both, tx, rx
lp_pause = both, tx, rx
link_pause = both, tx, rx
That would be far, far simpler.
> (c) dladm show-ether will print something user-friendly like the output
> below , which captures all the info in the ieee802.3(5) man page.
>
> The objective of "show-ether" is to summarize the state of the
> link; the {set,show}-linkprop commands should be used to actually
> set/get the syntax for setting each of these properties.
>
> local link state: up, full duplex;
> flow control: pause = XXX, asmpause = XXX;
> Transceiver address = XXX, id = XXX, type = "10 Mb/s"
>
These tables have to be extended to add 1g and 10g support, btw.
> ------------------------------------------------------
> capable advertised link-partner
> advertised
> ------------------------------------------------------
> autoneg
> speed
> duplex
> rem_fault
> pause
> asm_pause
> ------------------------------------------------------
>
> Comments?
>
Thanks. :-)
-- Garrett
> --Sowmini
> _______________________________________________
> brussels-dev mailing list
> brussels-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/brussels-dev
>