On Sun, Dec 02, 2007 at 07:34:41PM -0500, Sowmini.Varadhan at Sun.COM wrote:
> > > 2490,2504:
> > > I find it odd that a mac layer interface is taking something called
> > > dld_* as an argument. also, only a few fields in the structure are
> > > used. it might be simpler to just expand the arglist and change
> > > the signature to:
> > >
> > > mac_set_prop(mac_handle_t mh, const char *name, mac_public_prop_t prop,
> > > void *val, uint_t valsize);
> > >
> > > dld_prnum_t should be changed to mac_public_prop_t and moved to mac.h.
> > >
> > > once the above is done, bge should not need to include dld.h.
> >
> > While this is true for public properties, both the pr_name and
> > the pr_number are needed (private properties need the pr_name)
> > So the signature will be changed as you suggest, except that
> > mac_prop_t will be defined as
> >
> > typedef struct mac_prop_s {
> > dld_prnum_t mac_pr_num
> > char *mac_pr_name;
> > } mac_prop_t;
> >
can you change dld_prnum_t to mac_prnum_t (or call it mac_prop_id_t
since num sounds like a count)?
e.g.
typedef struct mac_prop_s {
mac_prop_id_t mp_id;
char *mp_name;
} mac_prop_t;
your other responses look fine.
eric
