Peter Memishian wrote:
> [ CC list trimmed. ]
>
> > 1. what is the command like?
> > For example,
> > dladm set-linkprop -p mac_flowctrl={rx,tx,bi,no} -i bge0
> >
> > rx: it means we could receive incoming pause frames from
> > peer
> > tx: it means we could transmit pause frames to peer
> > bi: it means we could both receive and transmit pause
> > frames from/to peer
> > no: it means we don't have flow control enabled. We will
> > not respond to pause frames incoming and will not send
> > out pause frames when congestion happens
> >
> > If the requested flowcontrol value is not applicable to
> > device, mac_flowctrl will remain old value and no change
> > to system.
>
> On the whole, I like this. A few comments and suggestions:
>
> * What does the "-i" mean in the set-linkprop example above?
>
>
Typo mistake, used to add a "-i" to refer interface before. :-) It
should "dladm set-linkprop ... bge0", without "-i".
> * While the property names need not be verbose, I'd strongly
> advise that they be pronouncable. Hence, I'm opposed to
> the "ctrl" in mac_flowctrl. I also think the underscore
> is hard to remember. Maybe just "flowcontrol"?
>
OK, I will try to fit that with other Brussels' name convention and make
that pronouncable and easy to remember.
"flowcontrol" is a good altenative, I think.
> * "Bi" seems like a strange abbreviation (often with a sexual
> connotation :-O); "both" seems more natural.
opps, really? =-O
I was just trying to make them two alphabet long, so that we have easily
formattable strings.
Is there any better 2 alphabet altenative?
> Likewise,
> since there isn't a "yes" value, "none" seems more natural
> than "no".
>
> Alternatively, the parameter could support a comma-separated
> list of values. Thus, the four combinations would be:
>
> "" (none)
> "rx"
> "tx"
> "rx,tx" (or "tx,rx")
>
I wonder it("rx,tx") is not as good as a single word, like "both" or "bo"?
> --
> meem
>
