On 10/12/09 22:16, Garrett D'Amore wrote: > All, > > I've converted hme to the common MII framework (and hence to Brussels). > This fixes at least one bug (it didn't work at forced 10 Mbps!), and > cleans up a *a lot* of code. hme shrinks by about 2200 lines. > > The webrev is here: > > http://cr.opensolaris.org/~gdamore/hme-mii
Hello Garrett, I have looked at only Brussels interfaces and here are my comments: hme.c: L123-L128: Since all the 4 private properties are per-interface, the comments above those lines are incorrect. They talk about making these parameters per-interface (which is already per-interface) and using ndd command. L130-133: Do we really need these to be global variables? They are used only for initiation and so can be represented as macros right. L1917: rv should be reset to 0. otherwise when everything is fine we will return (ENOTSUP) or else @L1950 return (ENOTSUP) and L1956 return (0) L1932: There is a missing 'else' clause. L72, L90, L127, L269: NIT: no need for ',' ~Girish
