On Sun, 21 Feb 2010, Greg Lewis wrote: > G'day Michael, > > On Fri, Feb 19, 2010 at 01:07:35PM -0800, Michael Allman wrote: >> Ok, I have a patch. How do I submit it? > > Sending it to the list for review (either directly or by putting up a URL > people can see it at) is a good first step :).
Before I send it, I have run into a pertinent issue. I am testing the jdk using the jdk/test/Makefile target jdk_nio2. Using the virgin BSD port (i.e. without my patch), I get a whole boatload of failures that look like FAILURE: FileChannel, offset 1, length 7 Transfers$Failure: Incorrect transfer length: 65533 (expected 7) at Transfers.testTo(Transfers.java:436) at Transfers.main(Transfers.java:527) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:613) at com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:94) at java.lang.Thread.run(Thread.java:717) Can someone else try running this test and report back their results? I ran it on Mac OS X v. 10.6.2. Cheers, Michael