On Tue, 2015-05-19 at 17:57 -0400, Jung-uk Kim wrote: > On 05/19/2015 14:18, Kurt Miller wrote: > > On Mon, 2015-05-18 at 15:16 -0400, Jung-uk Kim wrote: > >> Ideally, I think we have to make this conditional by adding a > >> variable, e.g., USE_STATIC_LIBJLI, and set it only on macosx by > >> default. Then we can set it from our port makefile depending on > >> target FreeBSD version. > > > > Using a single USE_STATIC_LIBJLI variable that controls static > > linking for bsd + other OS's turned out to be not straightforward > > since the findstring matching related to static linking libjli is > > not uniform. In some places it is 'bsd macosx' and others it is > > 'bsd macosx aix' or 'bsd macosx windows aix'. > > > > Instead of USE_STATIC_LIBJLI that applies to all os, I went with a > > var called BSD_STATIC_LIBJLI that gets set to 'bsd' only when > > --enable-static-libjli is configured and the OS is 'bsd'. Otherwise > > BSD_STATIC_LIBJLI is left blank. This allows me to use it in the > > non-uniform findstring matches. See the diffs below for details. > > > > There are two parts to the diff, jdk8 and jdk8/jdk separated below. > > I didn't include the regenerated generated-configure.sh part, but > > would commit that as well. > > > > Please take a look at the diffs and provide feedback if there's a > > problem with it. I've tested builds without --enable-static-libjli > > and with it (w/--disable-debug-symbols) on OpenBSD and its working > > well for me. > > Working as advertised on FreeBSD-current for me. > > Thanks! > > Jung-uk Kim >
Thanks for testing. I'll commit it shortly. -Kurt
