On Mon, 2 Mar 2026 14:55:38 GMT, Harald Eilertsen <[email protected]> wrote:
>> This basically allows configure to complete and set up a configuration >> suitable for building the BSD port for supported platforms (FreeBSD, OpenBSD >> and NetBSD.) >> >> The flag `_BSDONLY_SOURCE` is defined for all the BSD's _except_ for Apple >> MacOS, while the existing `_ALLBSD_SOURCE` _includes_ Apple MacOS. >> >> For the BSD's we set the `OPENJDK_TARGET_OS_ENV` variable to distinct values >> reflecting the BSD variant being built. This is used to distinguish build >> flags, library locations and what libraries and modules to include for the >> various builds. >> >> As an example, FreeBSD includes the ALSA library, and should build the >> Serviceability Agent, while the other BSD's do not. >> >> This work was sponsored by: The FreeBSD Foundation > > Harald Eilertsen has updated the pull request incrementally with one > additional commit since the last revision: > > Break too long lines > > This work was sponsored by: The FreeBSD Foundation I'm good with this, although obviously it just fixes configure :). I had a couple of optional minor suggestions (although this matching the current way we've had it in the port is probably a positive not to ignore) make/autoconf/jdk-options.m4 line 196: > 194: if test "x$OPENJDK_TARGET_OS_ENV" = xbsd.netbsd ; then > 195: INCLUDE_SA=false > 196: fi Maybe we should do this with `||` rather than a separate conditional like we have in other spots in the file? make/autoconf/platform.m4 line 498: > 496: if test "x$OPENJDK_$1_OS" = xbsd -o "x$OPENJDK_$1_OS" = xlinux \ > 497: && test "x$OPENJDK_$1_CPU" = xx86; then > 498: # On linux and BSD only, we replace x86 with i386. This should probably use `||` rather than `-o` ------------- Marked as reviewed by glewis (Lead). PR Review: https://git.openjdk.org/bsd-port/pull/3#pullrequestreview-3893628368 PR Review Comment: https://git.openjdk.org/bsd-port/pull/3#discussion_r2887540501 PR Review Comment: https://git.openjdk.org/bsd-port/pull/3#discussion_r2887542766
