On Tue, 17 Mar 2026 16:51:08 GMT, Thomas Stuefe <[email protected]> wrote:
>> make/autoconf/platform.m4 line 498:
>>
>>> 496: if test "x$OPENJDK_$1_OS" = xbsd -o "x$OPENJDK_$1_OS" = xlinux \
>>> 497: && test "x$OPENJDK_$1_CPU" = xx86; then
>>> 498: # On linux and BSD only, we replace x86 with i386.
>>
>> Small nit, I had to read twice to see this is correct. Maybe a `{ [ "x$OS" =
>> "xbsd" ] || [ "$OS" = "xlinux" ]; } && [ "x$CPU" = "xx86" ];` would be
>> clearer. Up to you.
>
> Also, is 32-bit a strong use case for BSD? Since 32-bit support will probably
> be removed at some point.
Good point! Most 32bit x86 code has been removed already, and we also don't
support that for OpenJDK releases that don't support it upstream. So we can
probably just drop this then :)
Thanks!
-------------
PR Review Comment:
https://git.openjdk.org/bsd-port/pull/4#discussion_r2948416256
