- Couldn't find a KEYS file to verify your signature (checked svn trunk)
- The 
bsf-engines/src/main/resources/META-INF/services/javax.script/ScriptEngineFactory
 doesn't
contain a license (if it doesn't run with the license, leave it out though)
- bsf-3.0-beta1-bin.tar.gz looks kind of weird in the META-INF directory (there 
is a META-INF
directory in there)
- You have built with jdk1.5, although the version supported is 1.4.2 (assuming 
you developed using
jdk1.4.2)

- Not sure if we are allowed to distribute the javax packages, since we didn't 
pass the TCK yet
(even though there is a disclaimer). I seem to recall reading somewhere (very 
vague, I know), that
you cannot use the package name until distributed (geir or someone else who 
knows better, please
correct me)
- Are we allowed to redistribute the engines in bsf-engines ? Doest BSF work 
without them ?
- What is the distribution directory in the src zip / tgz ?
- No site in source (maybe useful in dist?)
- No javadoc in binary dist

Some are blocking, some are not (also depending on some answers)  :)

Mvgr,
Martin



ant elder wrote:
> Please review and vote on the BSF 3.0-beta1 release.
> 
> The source, binary, and maven artifacts are at:
> http://people.apache.org/~antelder/bsf/3.0-beta1/
> 
> The svn tag is at:
> https://svn.apache.org/repos/asf/jakarta/bsf/tags/bsf-3.0-beta1/
> 
> Here's my +1 (non-binding I believe)
> 
>   ...ant
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to