On 23/03/2009, ant elder <ant.el...@gmail.com> wrote: > Thanks seb and rony for you thorough reviews, i think i've fixed all > the points raised and I've respun the release, artifacts at: > > > http://people.apache.org/~antelder/bsf/3.0-beta3-RC1/
MD5 hash files have a format which may not work with some automated checking utilities. [can be fixed with a simple edit] > > and SVN tag at: > > > https://svn.apache.org/repos/asf/jakarta/bsf/tags/bsf-3.0-beta3 The file RELEASE_NOTES is not in the source archive. Some missing SVN properties: svn ps svn:eol-style native RELEASE_NOTES svn ps svn:eol-style native testing/jruby-1.1.2/pom.xml svn ps svn:eol-style native testing/jruby-1.1.2/src/test/java/org/apache/bsf/testing/javascript/RubyTestcase.java svn ps svn:eol-style native testing/jruby-1.2.0/pom.xml svn ps svn:eol-style native testing/jruby-1.2.0/src/test/java/org/apache/bsf/testing/javascript/RubyTestcase.java [Can be fixed later] > > Please review, if there are no other issues found I'll start a release > vote shortly. > The file: bsf-engines/src/main/resources/META-INF/services/javax.script.ScriptEngineFactory has a lot of references to what appear to be Sun-specific classes, e.g. com.sun.script.freemarker.FreeMarkerScriptEngineFactory com.sun.script.groovy.GroovyScriptEngineFactory com.sun.script.jacl.JaclScriptEngineFactory com.sun.script.jaskell.JaskellScriptEngineFactory etc. Does this mean the code will only work with Sun Java libraries? == "mvn test" failed: [...] create-bsf-all: [unzip] Expanding: C:\Documents and Settings\User\.m2\repository\org\apache\bsf\bsf-api\3.0-beta3\bsf-api-3.0-beta3.jar into C:\ReleaseCheck\bsf-3 .0-beta3-src\distribution\target\bsf-all [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] An Ant BuildException has occured: The following error occurred while executing this line: C:\ReleaseCheck\bsf-3.0-beta3-src\distribution\build.xml:30: Error while expanding C:\Documents and Settings\User\.m2\repository\org\apache\bsf\bsf-ap i\3.0-beta3\bsf-api-3.0-beta3.jar java.io.FileNotFoundException: C:\Documents and Settings\User\.m2\repository\org\apache\bsf\bsf-api\3.0-beta3\bsf-api-3.0-beta3.jar (The system cannot find the path specified) However, I then ran "mvn" and that worked, as did a subsequent "mvn test". Also, the encoding needs to be specified: [WARNING] Using platform encoding (Cp1252 actually) to copy filtered resources, i.e. build is platform dependent! > ...ant > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: bsf-dev-unsubscr...@jakarta.apache.org > For additional commands, e-mail: bsf-dev-h...@jakarta.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: bsf-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: bsf-dev-h...@jakarta.apache.org
