Branch: refs/heads/master
Home: https://github.com/btcsuite/btcd
Commit: 63af0dbca9f72c5c624a5b72a7d88f3bf8cff009
https://github.com/btcsuite/btcd/commit/63af0dbca9f72c5c624a5b72a7d88f3bf8cff009
Author: Dave Collins <[email protected]>
Date: 2013-06-12 (Wed, 12 Jun 2013)
Changed paths:
A .gitignore
A README.md
Log Message:
-----------
Initial commit.
Commit: 119777015909a98595885c8d80cb8d06aff7aab8
https://github.com/btcsuite/btcd/commit/119777015909a98595885c8d80cb8d06aff7aab8
Author: Dave Collins <[email protected]>
Date: 2013-06-13 (Thu, 13 Jun 2013)
Changed paths:
A LICENSE
M README.md
A address.go
A address_test.go
A cov_report.sh
A doc.go
A internal_test.go
A log.go
A opcode.go
A opcode_test.go
A script.go
A script_test.go
A stack.go
A stack_test.go
A test_coverage.txt
Log Message:
-----------
Initial implementation.
Commit: 2a8cf9f44f2a501fcd6df72662fdaa529813a073
https://github.com/btcsuite/btcd/commit/2a8cf9f44f2a501fcd6df72662fdaa529813a073
Author: Dave Collins <[email protected]>
Date: 2013-06-13 (Thu, 13 Jun 2013)
Changed paths:
M opcode.go
Log Message:
-----------
Use correct import path for btcec.
Commit: bc41004b03fd08a3c1ad1d0833ba503668c94c23
https://github.com/btcsuite/btcd/commit/bc41004b03fd08a3c1ad1d0833ba503668c94c23
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-18 (Tue, 18 Jun 2013)
Changed paths:
M script.go
Log Message:
-----------
Use errors.New() not fmt.Errorf() when no fmt string.
Commit: 7b08a4e127a7c361287e6e55c6aad433cf2568ed
https://github.com/btcsuite/btcd/commit/7b08a4e127a7c361287e6e55c6aad433cf2568ed
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-18 (Tue, 18 Jun 2013)
Changed paths:
M script.go
Log Message:
-----------
Number of operations is per-script not per-transaction.
Reset the counter at the end of each script.
Commit: df0c0b27d19ee54019593f227b5e888652242cc9
https://github.com/btcsuite/btcd/commit/df0c0b27d19ee54019593f227b5e888652242cc9
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-18 (Tue, 18 Jun 2013)
Changed paths:
M script.go
M test_coverage.txt
Log Message:
-----------
Factor the end-of-script error handling into a function.
Use it to reduce code dpulication in the bip16 case.
In addition we export it so that that a user could run:
for !done && err == nil {
done, err = s.Step()
}
err = s.CheckErrorCondition()
manually instead of having to run Execute().
Commit: 4692d64f68fb145a2f4f97cf51bd32593b9ec87d
https://github.com/btcsuite/btcd/commit/4692d64f68fb145a2f4f97cf51bd32593b9ec87d
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-18 (Tue, 18 Jun 2013)
Changed paths:
M script_test.go
M test_coverage.txt
Log Message:
-----------
permit tests expect fail for nonspecified return code.
Use this to test the pubkey paths in checksig which return btcec errors
which we don't define. all of the other active tests know the return
code we need.
Commit: 5e82baf476ae08663fc010b6992cf9af09b64308
https://github.com/btcsuite/btcd/commit/5e82baf476ae08663fc010b6992cf9af09b64308
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-19 (Wed, 19 Jun 2013)
Changed paths:
M stack_test.go
Log Message:
-----------
add some basic tests for stack.PopInt()
Commit: 501b7113011af5bb453c3f7f4baccb432984fdab
https://github.com/btcsuite/btcd/commit/501b7113011af5bb453c3f7f4baccb432984fdab
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-19 (Wed, 19 Jun 2013)
Changed paths:
M stack.go
M test_coverage.txt
Log Message:
-----------
int.Sign() in go will never return negative for zero.
So remove the -0 handling in fromInt, only toInt needs it.
Commit: 625541e202a1d7a2916fcf08e180161ec6331574
https://github.com/btcsuite/btcd/commit/625541e202a1d7a2916fcf08e180161ec6331574
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-19 (Wed, 19 Jun 2013)
Changed paths:
M stack_test.go
M test_coverage.txt
Log Message:
-----------
add some testing for byte format in stack.PushInt()
should verify all the formats now.
pain causes endian little.
Commit: 8035de426b37952dab8654a18dc9b04099dcc7c9
https://github.com/btcsuite/btcd/commit/8035de426b37952dab8654a18dc9b04099dcc7c9
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-19 (Wed, 19 Jun 2013)
Changed paths:
M internal_test.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
Check that the pc validation code works ok.
Add a testing only interface to set the pc and set it to a few invalid
settings to check that step and disasmPC all blow up correctly.
Commit: bac455cdd2326897b3e56539081cdd19212504e9
https://github.com/btcsuite/btcd/commit/bac455cdd2326897b3e56539081cdd19212504e9
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-20 (Thu, 20 Jun 2013)
Changed paths:
M opcode.go
M opcode_test.go
M test_coverage.txt
Log Message:
-----------
Fix reversed test bug with the max operations handling
We were counting the number of push ops instead of the number of non
push ops. Add tests that found this (checking tha the max operations
check fires).
Commit: 25624bc6a707df97ea0cec95b9f4b09ab3bb8fda
https://github.com/btcsuite/btcd/commit/25624bc6a707df97ea0cec95b9f4b09ab3bb8fda
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-20 (Thu, 20 Jun 2013)
Changed paths:
M opcode_test.go
M test_coverage.txt
Log Message:
-----------
check that OP_CHECK_MULTISIG also triggers on too many ops
Commit: 421a213a4f00a5e807e15092371c15bf933254b2
https://github.com/btcsuite/btcd/commit/421a213a4f00a5e807e15092371c15bf933254b2
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-20 (Thu, 20 Jun 2013)
Changed paths:
M script.go
Log Message:
-----------
Stop modifying the passed tx in NewScript.
The only time we need to zero out scripts is for calcScriptHash which operates
on a deep copy anyway. This should make the tx passed to us unmodified now.
Commit: 03696a88749d1fb99c46612e0a8de8f2244779f1
https://github.com/btcsuite/btcd/commit/03696a88749d1fb99c46612e0a8de8f2244779f1
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-20 (Thu, 20 Jun 2013)
Changed paths:
M opcode_test.go
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
Add functions to count the number of signature operations in a script.
To be usd for validation. Most of the codepaths teste, a few tests
missing for cases needed tests in the validation codepaths too. To be
worked on in tree.
Commit: 8fe24958bb3cf21ee66663bd1b3e3b2f73df7703
https://github.com/btcsuite/btcd/commit/8fe24958bb3cf21ee66663bd1b3e3b2f73df7703
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-21 (Fri, 21 Jun 2013)
Changed paths:
M script_test.go
M test_coverage.txt
Log Message:
-----------
Test the unfinished condition of CheckErrorCondition
Commit: 53ba8fb83423ef257086abf53f036d29163fd0f3
https://github.com/btcsuite/btcd/commit/53ba8fb83423ef257086abf53f036d29163fd0f3
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-21 (Fri, 21 Jun 2013)
Changed paths:
M opcode_test.go
M script.go
M script_test.go
M stack_test.go
Log Message:
-----------
gofmt
Commit: 2bdaebfa740058350727812622766e9cff49ffec
https://github.com/btcsuite/btcd/commit/2bdaebfa740058350727812622766e9cff49ffec
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-24 (Mon, 24 Jun 2013)
Changed paths:
M script_test.go
M test_coverage.txt
Log Message:
-----------
some more tests for GetPreciseSigOpsCount. total coverage now.
Commit: 4a87e6e3a7ba1b5509103ef7f6961fb0e32adea3
https://github.com/btcsuite/btcd/commit/4a87e6e3a7ba1b5509103ef7f6961fb0e32adea3
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-25 (Tue, 25 Jun 2013)
Changed paths:
M script_test.go
M test_coverage.txt
Log Message:
-----------
Test a few failure cases of p2sh txs.
Commit: 7e937fae7540f3966b641a06659f857114ada70d
https://github.com/btcsuite/btcd/commit/7e937fae7540f3966b641a06659f857114ada70d
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-25 (Tue, 25 Jun 2013)
Changed paths:
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
testing for the case where a p2sh sigscript isn't pushonly.
Also providing a defined error (from NewScript) for that case.
Commit: 7ae307abfd309d4ea1aa592c232843aa218b21a0
https://github.com/btcsuite/btcd/commit/7ae307abfd309d4ea1aa592c232843aa218b21a0
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-26 (Wed, 26 Jun 2013)
Changed paths:
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
Fix case where we have an empty script that isn't the first.
Silly check needed to confirm it was the first script. Add test for this case.
Commit: d6161f0d4136eaaac7fb17eb9ed6c958d6afbfdb
https://github.com/btcsuite/btcd/commit/d6161f0d4136eaaac7fb17eb9ed6c958d6afbfdb
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-26 (Wed, 26 Jun 2013)
Changed paths:
M address.go
M address_test.go
M internal_test.go
M script.go
M test_coverage.txt
Log Message:
-----------
fix ScriptToAddress when called with 0 length script.
It did work by luck before, but now it works no matter what the template
tables say. Add tests for the other error cases and internal data
assertions.
Commit: df898ae1dd7ec7a523f33491166b94c8e4993d33
https://github.com/btcsuite/btcd/commit/df898ae1dd7ec7a523f33491166b94c8e4993d33
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-26 (Wed, 26 Jun 2013)
Changed paths:
M script_test.go
M test_coverage.txt
Log Message:
-----------
test a few non-standards script types to hit some edge cases.
Commit: dd216cef29313a8fe77ee20367915d1dc866eee4
https://github.com/btcsuite/btcd/commit/dd216cef29313a8fe77ee20367915d1dc866eee4
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-26 (Wed, 26 Jun 2013)
Changed paths:
M opcode_test.go
M test_coverage.txt
Log Message:
-----------
Test pushing at and beyond the boundary for largest stack item.
Commit: bcd8c9d2276d5640a3ca14c485e0bdf01e6e2222
https://github.com/btcsuite/btcd/commit/bcd8c9d2276d5640a3ca14c485e0bdf01e6e2222
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-27 (Thu, 27 Jun 2013)
Changed paths:
M opcode_test.go
Log Message:
-----------
gofmt
Commit: 244ce4b96ede62b330aaf7fddb852dc7f2801519
https://github.com/btcsuite/btcd/commit/244ce4b96ede62b330aaf7fddb852dc7f2801519
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-27 (Thu, 27 Jun 2013)
Changed paths:
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
add IsPayToScriptHash api
To tell ifa bytestream matches teh p2sh pattern.
Commit: e5a275679578a51e869e313deca93f736d6380f1
https://github.com/btcsuite/btcd/commit/e5a275679578a51e869e313deca93f736d6380f1
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-27 (Thu, 27 Jun 2013)
Changed paths:
M opcode_test.go
M script.go
M test_coverage.txt
Log Message:
-----------
Test empty scripts and out of bounds for DisasmScript()
give disasmscript a defined error return for out of bounds.
Commit: 89578c985ac3be6f7ab768bead547bb103022dfc
https://github.com/btcsuite/btcd/commit/89578c985ac3be6f7ab768bead547bb103022dfc
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-27 (Thu, 27 Jun 2013)
Changed paths:
M opcode_test.go
M test_coverage.txt
Log Message:
-----------
add basic test for OP_SHA1
yup, it produces the sha of the data.
Commit: c41330e772e033fa1e5ff09390f2e66b0504293a
https://github.com/btcsuite/btcd/commit/c41330e772e033fa1e5ff09390f2e66b0504293a
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-28 (Fri, 28 Jun 2013)
Changed paths:
M internal_test.go
M script.go
M test_coverage.txt
Log Message:
-----------
Add basic test for if internal opcode definitions are buggy.
Commit: 4d31b2c850c31b81d64c3cb53545352f04f09ec9
https://github.com/btcsuite/btcd/commit/4d31b2c850c31b81d64c3cb53545352f04f09ec9
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-06-28 (Fri, 28 Jun 2013)
Changed paths:
M README.md
Log Message:
-----------
Remove blurb about 100% coverage and replace with comprehensive.
btcscript contains an amount of debug logging that is very useful to
have. We have agreed that testing this isn't realy practical or indeed
really useful and thus is rather unlikely to grow test coverage any time
soon.
Commit: bedaddb790b19cfdf8ca6ca112cdca0cd032db9c
https://github.com/btcsuite/btcd/commit/bedaddb790b19cfdf8ca6ca112cdca0cd032db9c
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-07-05 (Fri, 05 Jul 2013)
Changed paths:
M internal_test.go
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
add GetScriptClass to return the internal script type of a script.
To be used to tell which class a script is (multisig, scripthash, pubkey,
pkhash, or nonstandard)
Commit: eb5de559ffca7572c5d7e3aad3adea2dd3999acc
https://github.com/btcsuite/btcd/commit/eb5de559ffca7572c5d7e3aad3adea2dd3999acc
Author: Dave Collins <[email protected]>
Date: 2013-07-06 (Sat, 06 Jul 2013)
Changed paths:
M script.go
Log Message:
-----------
Fix a couple of comment typos for the word execute.
Commit: e7f9415e4f5348c479d4f27ccc4c1767a50a4854
https://github.com/btcsuite/btcd/commit/e7f9415e4f5348c479d4f27ccc4c1767a50a4854
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-07-25 (Thu, 25 Jul 2013)
Changed paths:
M opcode_test.go
M script.go
M script_test.go
Log Message:
-----------
Return 0 for bad scripts from sigops code instead of an error.
matches how bitcoind behaves.
Commit: fe2233c851a59c3f646f63755372cd20fcf53e22
https://github.com/btcsuite/btcd/commit/fe2233c851a59c3f646f63755372cd20fcf53e22
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-07-29 (Mon, 29 Jul 2013)
Changed paths:
M script.go
Log Message:
-----------
Make count sigops always count up to the point of parse failure.
We do this by allowing the parser to return the list of parsed objects
(it is an internal only api anyway) and then we use this in the sigops
counting and ignore the error. This change due to bitcoind
compatability.
Commit: 22c29c4316e047217352647ac52b77f8805295d0
https://github.com/btcsuite/btcd/commit/22c29c4316e047217352647ac52b77f8805295d0
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-07-29 (Mon, 29 Jul 2013)
Changed paths:
M opcode.go
M opcode_test.go
M script.go
M test_coverage.txt
Log Message:
-----------
Perform pushed length checks at exec time, not parse.
To match bitcoind behaviour. Fix tests to agree with this direction.
Commit: 927d846f067df1ef6f4dbc615fe592a7c2d4fd33
https://github.com/btcsuite/btcd/commit/927d846f067df1ef6f4dbc615fe592a7c2d4fd33
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-07-31 (Wed, 31 Jul 2013)
Changed paths:
M script.go
Log Message:
-----------
Handle bad input in sighash single.
The bitcoinj test suite actually uses it (the only thing i've seen that
does). Specifically it uses it with a bad input which returns a hash of
1.
Commit: 118014a5b4323656fd2dc910359e45def2761523
https://github.com/btcsuite/btcd/commit/118014a5b4323656fd2dc910359e45def2761523
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-07-31 (Wed, 31 Jul 2013)
Changed paths:
M script.go
M script_test.go
Log Message:
-----------
gofmt.
Commit: 26fb20e4ed73385b5bf3bbc04754831ac2f53bb5
https://github.com/btcsuite/btcd/commit/26fb20e4ed73385b5bf3bbc04754831ac2f53bb5
Author: Dave Collins <[email protected]>
Date: 2013-08-05 (Mon, 05 Aug 2013)
Changed paths:
M README.md
M doc.go
M opcode_test.go
M script.go
M script_test.go
Log Message:
-----------
Remove need for protocol version.
This commit modifies the code to no longer require a protocol version. It
does this by making use of the new Serialize function in btcwire.
Unfortuantely this does entail a public API change which I generally don't
like to do, but eliminating the usage of the protocol version throughout
the codebase was important enough to warrant the change.
Commit: 17d37e3b060fd6d2693b40a189271a9e17cd814b
https://github.com/btcsuite/btcd/commit/17d37e3b060fd6d2693b40a189271a9e17cd814b
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-08-06 (Tue, 06 Aug 2013)
Changed paths:
M opcode_test.go
Log Message:
-----------
Fix up some ErrorF strings in tests.
One was missing a format directive. the others changed for consistency.
Appeases go vet.
Commit: 87e976a732988a9469d63ee0a64f65c767ae2993
https://github.com/btcsuite/btcd/commit/87e976a732988a9469d63ee0a64f65c767ae2993
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-09-25 (Wed, 25 Sep 2013)
Changed paths:
M opcode.go
Log Message:
-----------
Add comment explaining OP_RESERVED behaviour with push ops.
Commit: a63edcd2dc3ef795712cf4422ee7dadc2bb99667
https://github.com/btcsuite/btcd/commit/a63edcd2dc3ef795712cf4422ee7dadc2bb99667
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-09-25 (Wed, 25 Sep 2013)
Changed paths:
M opcode.go
M script.go
M test_coverage.txt
Log Message:
-----------
preallocate a few arrays.
When we do append loops, make an educated guess as to the size and make an array
with that capacity to avoid extra copying.
Doesn't affect the speed of the tests, over 4 runs the difference was lost in
the noise.
Commit: 0a3e7f682b23aeb621e44617afcdf2c0d8fbd814
https://github.com/btcsuite/btcd/commit/0a3e7f682b23aeb621e44617afcdf2c0d8fbd814
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-09-26 (Thu, 26 Sep 2013)
Changed paths:
M opcode.go
M stack.go
Log Message:
-----------
Avoid the risk of leaking small amounts of memory.
Removing from the bottom of a stack (nipN(depth)) would leak the first
entry in the array by slicing [1:], leaving array[0] dangling an
inaccessible (but unable to be freed until the whole slice is gone). We
left it like this for a while, but best not to leak the memory. Happens
rarely so the performance hit shouldn't matter that much. Do the same
thing for condstack.
Commit: 29ed09cc98bbad0b71a6896c5845489152886a38
https://github.com/btcsuite/btcd/commit/29ed09cc98bbad0b71a6896c5845489152886a38
Author: Dave Collins <[email protected]>
Date: 2013-09-30 (Mon, 30 Sep 2013)
Changed paths:
M script.go
M test_coverage.txt
Log Message:
-----------
Add IsPushOnlyScript.
This commit adds an exported function, IsPushOnlyScript, which can be used
to tell whether or not a script only pushes data (only contains opcodes
that push data).
Commit: a5f81fc5457eec41c1438f12b0d92a27a586039f
https://github.com/btcsuite/btcd/commit/a5f81fc5457eec41c1438f12b0d92a27a586039f
Author: Josh Rickmar <[email protected]>
Date: 2013-10-01 (Tue, 01 Oct 2013)
Changed paths:
M internal_test.go
M opcode.go
M script.go
M script_test.go
M stack.go
M test_coverage.txt
Log Message:
-----------
Add PayToPubKeyHashScript and SignatureScript functions.
PayToPubKeyHashScript generates a new pay to pubkey hash script to use
as the pkScript when creating new transactions. If the passed pubkey
hash is an invalid size, StackErrInvalidOpcode will be returned as an
error.
SignatureScript returns the signature script necessary to validate a
single input of a transaction.
This also adds sanity checking for serializing scripts into byte
slices. If the length of a serialized opcode does not equal the
expected length, StackErrInvalidOpcode will be returned when unparsing
a []parsedOpcode.
New internal tests were added to verify checks for valid and invalid
parsed opcodes.
Commit: 52a1488eaf9c1037a7e80dc29e64a2b698ce5737
https://github.com/btcsuite/btcd/commit/52a1488eaf9c1037a7e80dc29e64a2b698ce5737
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-10-08 (Tue, 08 Oct 2013)
Changed paths:
M internal_test.go
M opcode.go
M opcode_test.go
M script_test.go
Log Message:
-----------
bitcoind only fails on invalid (undefined) opcodes when they are executed.
So add entries for them that disassemble and parse ok, but will fail
when executed with the appropriate error. Add a full suite of tests to confirm
that this happens.
Found by a strange transaction in testnet.
Commit: 83a19b239dad7921b0f23917aee9aec9c144e466
https://github.com/btcsuite/btcd/commit/83a19b239dad7921b0f23917aee9aec9c144e466
Author: Josh Rickmar <[email protected]>
Date: 2013-10-08 (Tue, 08 Oct 2013)
Changed paths:
M address.go
M address_test.go
M internal_test.go
Log Message:
-----------
Replace ScriptToAddress with ScriptToAddrHash to return an address hash.
Commit: 8a743c344a643b22024a23c25dca5f0e0d458273
https://github.com/btcsuite/btcd/commit/8a743c344a643b22024a23c25dca5f0e0d458273
Author: Josh Rickmar <[email protected]>
Date: 2013-10-08 (Tue, 08 Oct 2013)
Changed paths:
M address.go
M script.go
M test_coverage.txt
Log Message:
-----------
Update all comments and test coverage with new func name
Commit: 7ff3d5f8718746d23c97d37caa3946de06fd580e
https://github.com/btcsuite/btcd/commit/7ff3d5f8718746d23c97d37caa3946de06fd580e
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-10-08 (Tue, 08 Oct 2013)
Changed paths:
M script.go
Log Message:
-----------
Handle sign extended numbers in parsing variable length opcodes.
Commit: 093ddbe1935156397173ca688eb1d1c579400d0a
https://github.com/btcsuite/btcd/commit/093ddbe1935156397173ca688eb1d1c579400d0a
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-10-09 (Wed, 09 Oct 2013)
Changed paths:
M script.go
Log Message:
-----------
*sigh*, accidentally commited a wrong chunk as well as the right chunk.
Fix length check back to what it should be.
Commit: 4e608c115fd141c12439c7706ee1120ebbc5fa4f
https://github.com/btcsuite/btcd/commit/4e608c115fd141c12439c7706ee1120ebbc5fa4f
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-10-09 (Wed, 09 Oct 2013)
Changed paths:
M stack.go
M stack_test.go
Log Message:
-----------
Prevent asInt() from modifying stack data.
The stack data is normally sliced from the actual script and btcscript is not
supposed to ever change the tx passed into it.
Add a test (and fix the other leading zeros tests) to stop this happening again.
Commit: 53ca29efadb8b3f4467a0f1e6782b7004e6b23c6
https://github.com/btcsuite/btcd/commit/53ca29efadb8b3f4467a0f1e6782b7004e6b23c6
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-10-10 (Thu, 10 Oct 2013)
Changed paths:
M stack.go
M stack_test.go
M test_coverage.txt
Log Message:
-----------
fix multi-byte bug in previous.
Use the right offset when working out if we should mask off the sign bit.
Add more tests that would have caught this case.
Commit: 003a41f66f5840674faa94022bc3cbd8892bb32e
https://github.com/btcsuite/btcd/commit/003a41f66f5840674faa94022bc3cbd8892bb32e
Author: Dale Rahn <[email protected]>
Date: 2013-10-10 (Thu, 10 Oct 2013)
Changed paths:
M stack.go
Log Message:
-----------
Slightly cleaner fix.
Commit: 40c75b27ac8103234379ef8243a8393019c8c708
https://github.com/btcsuite/btcd/commit/40c75b27ac8103234379ef8243a8393019c8c708
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-10-17 (Thu, 17 Oct 2013)
Changed paths:
M script.go
M script_test.go
M stack_test.go
M test_coverage.txt
Log Message:
-----------
Add CalcScriptInfo entrypoint to return info about scriptpairs.
Specficially the class of the pkScript, the expected numbers of
arguments and the number of sigops.
Commit: 8eead5217d6af35b9def1558fc0529bac3af5067
https://github.com/btcsuite/btcd/commit/8eead5217d6af35b9def1558fc0529bac3af5067
Author: David Hill <[email protected]>
Date: 2013-10-25 (Fri, 25 Oct 2013)
Changed paths:
M opcode.go
M opcode_test.go
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
Add flag bitmask to NewScript for canonical sig checks.
This removes the bip16 bool from NewScript and adds it to flags (with
the constant ScriptBip16), and also adds a new flag,
ScriptCanonicalSignatures, which will call btcec.ParseDERSignature
parsing a signature during an Execute. This is needed to emulate
bitcoind behavior, as bitcoind performs canonical signature validation
(DER format) in some places (like mempool acceptance) but not others
(like block validation).
Updated tests and test coverage file to reflect changes.
Commit: b0899204d9e33dd0270c9993e2c65ac7e5631514
https://github.com/btcsuite/btcd/commit/b0899204d9e33dd0270c9993e2c65ac7e5631514
Author: Josh Rickmar <[email protected]>
Date: 2013-10-27 (Sun, 27 Oct 2013)
Changed paths:
M doc.go
Log Message:
-----------
Update NewScript example after API change.
This change updates the doc.go documentation file with the correct use
of the new (since 8eead5217d6af35b9def1558fc0529bac3af5067) API used
for passing additional options when creating new script engines.
Spotted by davec@
Commit: e8321441afb7491172919704278059f7c2991920
https://github.com/btcsuite/btcd/commit/e8321441afb7491172919704278059f7c2991920
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-11-06 (Wed, 06 Nov 2013)
Changed paths:
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
add a stringer for ScriptClass
Commit: 3aaafbd7faafcb5a5b5e5ec4f208224df3abbb6e
https://github.com/btcsuite/btcd/commit/3aaafbd7faafcb5a5b5e5ec4f208224df3abbb6e
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M opcode.go
Log Message:
-----------
handle op_checksig with an empty signature on the stack.
Crash found by jy-p, fix by me.
Commit: f0e7011b6f62c067bc6719f810e30c7bb03c1908
https://github.com/btcsuite/btcd/commit/f0e7011b6f62c067bc6719f810e30c7bb03c1908
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M opcode.go
Log Message:
-----------
fix previous.
test patch, commit patch. Not the other way around, dumbass.
Commit: f4a6449ad3b90d0c830bf2895b83ced8d5fb91e9
https://github.com/btcsuite/btcd/commit/f4a6449ad3b90d0c830bf2895b83ced8d5fb91e9
Author: Owain G. Ainsworth <[email protected]>
Date: 2013-11-07 (Thu, 07 Nov 2013)
Changed paths:
M opcode.go
Log Message:
-----------
Actually just fail the opcode, not returning an error.
should fix some crazy script on testnet.
Commit: 1ca389aa3d063d813273d290a5102d6d088b4dfb
https://github.com/btcsuite/btcd/commit/1ca389aa3d063d813273d290a5102d6d088b4dfb
Author: Dave Collins <[email protected]>
Date: 2013-11-14 (Thu, 14 Nov 2013)
Changed paths:
M script.go
Log Message:
-----------
Go fmt.
Commit: e2770d3691ee85c10ec40cb4eecbb3ecf97127cc
https://github.com/btcsuite/btcd/commit/e2770d3691ee85c10ec40cb4eecbb3ecf97127cc
Author: Dave Collins <[email protected]>
Date: 2013-11-14 (Thu, 14 Nov 2013)
Changed paths:
M script_test.go
Log Message:
-----------
Go fmt.
Commit: 80e8c589d87ab0b6a3e5361324cefb50a7358298
https://github.com/btcsuite/btcd/commit/80e8c589d87ab0b6a3e5361324cefb50a7358298
Author: Dave Collins <[email protected]>
Date: 2013-11-14 (Thu, 14 Nov 2013)
Changed paths:
M script_test.go
Log Message:
-----------
Bring back nonstand script class stringer test.
Commit: 8550b1168527e51c261e11ec58deb3fb22fcccf8
https://github.com/btcsuite/btcd/commit/8550b1168527e51c261e11ec58deb3fb22fcccf8
Author: Dave Collins <[email protected]>
Date: 2013-11-14 (Thu, 14 Nov 2013)
Changed paths:
M script_test.go
Log Message:
-----------
Fix missing comma.
Commit: c33bd15df2cce3edfa021fbe67b4e56192d180f5
https://github.com/btcsuite/btcd/commit/c33bd15df2cce3edfa021fbe67b4e56192d180f5
Author: Dave Collins <[email protected]>
Date: 2013-11-14 (Thu, 14 Nov 2013)
Changed paths:
M script.go
Log Message:
-----------
Add a new func CalcMultiSigStats.
This commit adds a new function to extract the number of pulic keys and
number of signatures from a multi-signature script.
ok @owainga
Commit: cfc2a4cc76e64ae18f898195c1b11d82b6321d33
https://github.com/btcsuite/btcd/commit/cfc2a4cc76e64ae18f898195c1b11d82b6321d33
Author: Dave Collins <[email protected]>
Date: 2013-11-14 (Thu, 14 Nov 2013)
Changed paths:
M script.go
Log Message:
-----------
Add support for nulldata standard scripts.
This commit adds the new standard script type for empty, but data carrying
and provably prunable transaction scripts.
Closes #2.
ok @owainga
Commit: d4c5b3d04d49097c0f17c81d29c183f4a1593f6c
https://github.com/btcsuite/btcd/commit/d4c5b3d04d49097c0f17c81d29c183f4a1593f6c
Author: Dave Collins <[email protected]>
Date: 2013-11-14 (Thu, 14 Nov 2013)
Changed paths:
M script_test.go
M test_coverage.txt
Log Message:
-----------
Add tests for new nulldata standard script type.
Commit: aa3cdbe7b1d0059c5f01c60595e233a2b40a8463
https://github.com/btcsuite/btcd/commit/aa3cdbe7b1d0059c5f01c60595e233a2b40a8463
Author: Marco Peereboom <[email protected]>
Date: 2013-11-19 (Tue, 19 Nov 2013)
Changed paths:
M opcode.go
Log Message:
-----------
use fastsha256
Commit: 58e5fd3aec94a7d9a5a5950dd3c0b63a8aba4e09
https://github.com/btcsuite/btcd/commit/58e5fd3aec94a7d9a5a5950dd3c0b63a8aba4e09
Author: Dave Collins <[email protected]>
Date: 2013-11-21 (Thu, 21 Nov 2013)
Changed paths:
M log.go
Log Message:
-----------
Use btclog for logging.
Commit: 18576ab105e9787a17490e230e052291c4eca273
https://github.com/btcsuite/btcd/commit/18576ab105e9787a17490e230e052291c4eca273
Author: Dave Collins <[email protected]>
Date: 2013-12-10 (Tue, 10 Dec 2013)
Changed paths:
A .travis.yml
M README.md
Log Message:
-----------
Add support for TravisCI.
Also add TravisCI build status badge to README.md.
Commit: c0c167cc15aa3b721c983fd775cdef7afb42de38
https://github.com/btcsuite/btcd/commit/c0c167cc15aa3b721c983fd775cdef7afb42de38
Author: Dave Collins <[email protected]>
Date: 2013-12-10 (Tue, 10 Dec 2013)
Changed paths:
M opcode_test.go
Log Message:
-----------
Remove logging bits from script_test.go.
The allows the tests to run without showing warning for malformed bits
(which are intentionally malformed for testing purposes). Also, the
tests would not compile since the new btclog backend was switched out.
This commit resolves that.
Commit: 4f4afedf39df65eceb4d7ca2b9b2eba4042cb49e
https://github.com/btcsuite/btcd/commit/4f4afedf39df65eceb4d7ca2b9b2eba4042cb49e
Author: Dave Collins <[email protected]>
Date: 2013-12-23 (Mon, 23 Dec 2013)
Changed paths:
M script.go
Log Message:
-----------
Use the new btcec Signature.Serialize API.
This commit modifies the code to use the new btcec Signature.Serialize API
instead of the internal sigDER which has now been removed. This closes #3.
ok @owainga
Commit: a5aaf90687aaafa6782363be478d9653d133ebcf
https://github.com/btcsuite/btcd/commit/a5aaf90687aaafa6782363be478d9653d133ebcf
Author: Francis Lam <[email protected]>
Date: 2014-01-02 (Thu, 02 Jan 2014)
Changed paths:
M address.go
M script.go
Log Message:
-----------
Added support to decode scripthash/multisig from pkscripts
Commit: 3f52f559eb6aa87e87e0249d471b1f70c88dcc20
https://github.com/btcsuite/btcd/commit/3f52f559eb6aa87e87e0249d471b1f70c88dcc20
Author: Francis Lam <[email protected]>
Date: 2014-01-02 (Thu, 02 Jan 2014)
Changed paths:
M address.go
M address_test.go
M script.go
Log Message:
-----------
Added tests for multisig scripts and fixed comments
Fixed up bad function comment headers
Added a small set of tests for the ScriptToAddrHashes function to test
functionality of a couple real multisig cases as well as error checking
Commit: 3a8ec0078b6a2a8fddf99a33f1e67ffb443b1b72
https://github.com/btcsuite/btcd/commit/3a8ec0078b6a2a8fddf99a33f1e67ffb443b1b72
Author: Francis Lam <[email protected]>
Date: 2014-01-02 (Thu, 02 Jan 2014)
Changed paths:
M address_test.go
Log Message:
-----------
Added another multisig test with compressed pubkey
Commit: 3d60bac2386ce1d1cbf49bc4c737178b08434b45
https://github.com/btcsuite/btcd/commit/3d60bac2386ce1d1cbf49bc4c737178b08434b45
Author: Dave Collins <[email protected]>
Date: 2014-01-03 (Fri, 03 Jan 2014)
Changed paths:
M script.go
Log Message:
-----------
Add new funcs for creating payment scripts.
This commit adds two new functions named PayToScriptHashScript and
PayToAddrScript. The first one creates and returns a public-key script
which pays to the provided script hash and conforms to BIP0016.
The second function takes the new btcutil.Address interface type and
returns an appropriate script to pay to the address type in the interface.
It currently works for btcutil.AddressPubKeyHash and
btcutil.AddressScriptHash.
Commit: 814c920c96974bcdcf5af43d505d63e1fb237460
https://github.com/btcsuite/btcd/commit/814c920c96974bcdcf5af43d505d63e1fb237460
Author: Dave Collins <[email protected]>
Date: 2014-01-03 (Fri, 03 Jan 2014)
Changed paths:
M script_test.go
M test_coverage.txt
Log Message:
-----------
Add tests for new payment script creation funcs.
Commit: eb4fc19b95258863af88859a4ba2934d5199ca76
https://github.com/btcsuite/btcd/commit/eb4fc19b95258863af88859a4ba2934d5199ca76
Author: Dave Collins <[email protected]>
Date: 2014-01-03 (Fri, 03 Jan 2014)
Changed paths:
M script.go
Log Message:
-----------
Modify DisasmString to return partial disassembly.
Rather than returning an empty string from DisasmString if a script fails
to parse, return the disassembly up to the point of the failure along with
[error] appended. The error is still returned in case the caller wants
more information about the script parse failure.
Commit: b7135909025c740fb009eb01d8c2a467c2c1d9d0
https://github.com/btcsuite/btcd/commit/b7135909025c740fb009eb01d8c2a467c2c1d9d0
Author: Dave Collins <[email protected]>
Date: 2014-01-04 (Sat, 04 Jan 2014)
Changed paths:
M script.go
Log Message:
-----------
Group the StackErrX definitions.
This improves the godoc display and provides a cleaner separation of the
error definitions from other variables.
Commit: 2005fae90834a88c31281ecf04cf697aba9d0d1e
https://github.com/btcsuite/btcd/commit/2005fae90834a88c31281ecf04cf697aba9d0d1e
Author: Dave Collins <[email protected]>
Date: 2014-01-04 (Sat, 04 Jan 2014)
Changed paths:
M address.go
M address_test.go
M internal_test.go
M opcode.go
M opcode_test.go
M script.go
M script_test.go
Log Message:
-----------
Change OP_CHECK_MULTISIG -> OP_CHECKMULTISIG.
This change was made to match the reference implementation.
Commit: e2f14e2cfa7cba1e46f960415244ca7545b24f13
https://github.com/btcsuite/btcd/commit/e2f14e2cfa7cba1e46f960415244ca7545b24f13
Author: Dave Collins <[email protected]>
Date: 2014-01-06 (Mon, 06 Jan 2014)
Changed paths:
M script.go
Log Message:
-----------
Fix comment typo.
Commit: 126991b60bc6ee1ef0196cd96e40f04058144229
https://github.com/btcsuite/btcd/commit/126991b60bc6ee1ef0196cd96e40f04058144229
Author: Dave Collins <[email protected]>
Date: 2014-01-07 (Tue, 07 Jan 2014)
Changed paths:
M opcode.go
M opcode_test.go
M test_coverage.txt
Log Message:
-----------
Make opcode disasm names match reference impl.
This commit modifies the names of opcdoes shown in the oneline script
disassembly to match the reference implementation. In particular
OP_1NEGATE, and OP_0 through OP_16 are changed to the raw numbers
they represent when doing oneline disassembly. When doing full
disassembly, the full opcode names are still shown.
ok @owainga.
Commit: 6c8003b064af105a468ca08a4c2f94c3d66915fc
https://github.com/btcsuite/btcd/commit/6c8003b064af105a468ca08a4c2f94c3d66915fc
Author: Dave Collins <[email protected]>
Date: 2014-01-07 (Tue, 07 Jan 2014)
Changed paths:
M address.go
R address_test.go
M internal_test.go
M script.go
Log Message:
-----------
Refactor and improve address extraction code.
This commit significantly changes the address extraction code. The
original code was written before some of the other newer code was written
and as a result essentially duplicated some of the logic for handling
standard scripts which is used elsewhere in the package.
The following is a summary of what has changed:
- CalcPkScriptAddrHashes, ScriptToAddrHash, and ScriptToAddrHashes have
been replaced by ExtractPkScriptAddresses
- The ScriptType type has been removed in favor of the existing
ScriptClass type
- The new function returns a slice of btcutil.Addresses instead of raw
hashes that the caller then needs to figure out what to do with to
convert them to proper addressses
- The new function makes use of the existing ScriptClass instead of an
nearly duplicate ScriptType
- The new function hooks into the existing infrastructure for parsing
scripts and identifying scripts of standard forms
- The new function only works with pkscripts to match the behavior of the
reference implementation - do note that the redeeming script from a p2sh
script is still considered a pkscript
- The logic combines extraction for all script types instead of using a
separate function for multi-signature transactions
- The new function ignores addresses which are invalid for some reason
such as invalid public keys
Commit: e50681264bb8373b82eda9fa1a0416d110741592
https://github.com/btcsuite/btcd/commit/e50681264bb8373b82eda9fa1a0416d110741592
Author: Dave Collins <[email protected]>
Date: 2014-01-07 (Tue, 07 Jan 2014)
Changed paths:
A address_test.go
M test_coverage.txt
Log Message:
-----------
Add 100% test coverage for ExtractPkScriptAddrs.
Commit: 565f11409c4a1fca39814e9f616a3dada8ca78c7
https://github.com/btcsuite/btcd/commit/565f11409c4a1fca39814e9f616a3dada8ca78c7
Author: Dave Collins <[email protected]>
Date: 2014-01-08 (Wed, 08 Jan 2014)
Changed paths:
M LICENSE
M address.go
M address_test.go
M doc.go
M internal_test.go
M log.go
M opcode.go
M opcode_test.go
M script.go
M script_test.go
M stack.go
M stack_test.go
Log Message:
-----------
Add 2014 to copyright dates.
Commit: b11f1620e26e0149faedb78d9037344e97e2df71
https://github.com/btcsuite/btcd/commit/b11f1620e26e0149faedb78d9037344e97e2df71
Author: Dave Collins <[email protected]>
Date: 2014-01-17 (Fri, 17 Jan 2014)
Changed paths:
M opcode.go
Log Message:
-----------
Remove warnings for errors that are returned.
ok @owainga.
Commit: e8881196d6b291753b956c9294ab066a891e2a61
https://github.com/btcsuite/btcd/commit/e8881196d6b291753b956c9294ab066a891e2a61
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-02-04 (Tue, 04 Feb 2014)
Changed paths:
M opcode.go
Log Message:
-----------
Fix a number of bugs in signature checking
When given badly formatted signature or pubkeys like in block
0000000000000001e4241fd0b3469a713f41c5682605451c05d3033288fb2244, transaction
fd9b541d23f6e9bddb34ede15c7684eeec36231118796b691ae525f95578acf1 we could fail
on strange scripts because we returned an error instead of failing the
opcode and putting a FALSE on the stack.
Fixes chainfork issue on the aforementioned block.
Commit: 13ba8607f73512ae8627e050f1bfbb7fc0f96850
https://github.com/btcsuite/btcd/commit/13ba8607f73512ae8627e050f1bfbb7fc0f96850
Author: Dave Collins <[email protected]>
Date: 2014-02-04 (Tue, 04 Feb 2014)
Changed paths:
M opcode.go
Log Message:
-----------
Gofmt.
Commit: 971fbf8b28711c26c939833bdf53ab286cde02a4
https://github.com/btcsuite/btcd/commit/971fbf8b28711c26c939833bdf53ab286cde02a4
Author: David Hill <[email protected]>
Date: 2014-02-04 (Tue, 04 Feb 2014)
Changed paths:
M internal_test.go
M opcode_test.go
M script.go
M script_test.go
Log Message:
-----------
gofmt
Commit: fcd73f75ea43b79e68eba9c0b111d01dc98e84b4
https://github.com/btcsuite/btcd/commit/fcd73f75ea43b79e68eba9c0b111d01dc98e84b4
Author: Dave Collins <[email protected]>
Date: 2014-02-19 (Wed, 19 Feb 2014)
Changed paths:
M script.go
Log Message:
-----------
Correct log trace for failed script execution.
The function needs to be wrapped by a newLogClosure for the logger to be
able to log it.
Commit: 1d360509f45df050a4acec531a4b2dfe2158fb2d
https://github.com/btcsuite/btcd/commit/1d360509f45df050a4acec531a4b2dfe2158fb2d
Author: Dave Collins <[email protected]>
Date: 2014-02-19 (Wed, 19 Feb 2014)
Changed paths:
M opcode.go
Log Message:
-----------
Correct handling for multi-sig zero signatures.
It is possible for a multisignature transaction to require zero
signatures. For example, input 2 of testnet transaction
b2d93dfd0b2c1a380e55e76a8d9cb3075dec9f4474e9485be008c337fd62c1f7
in block number 185117.
Previously the code was pushing a false to the stack when no
valid signatures were found. This commit remedies that by pushing true
when no valid signatures were found, but none are required. Otherwise it
still pushes false when no valid signatures were found, but some are
required.
Fixes #7.
ok @owainga
Commit: 37a45ec68371bb98d7f2f7f28c6175669886cb56
https://github.com/btcsuite/btcd/commit/37a45ec68371bb98d7f2f7f28c6175669886cb56
Author: Dave Collins <[email protected]>
Date: 2014-02-19 (Wed, 19 Feb 2014)
Changed paths:
M address.go
M script.go
Log Message:
-----------
Allow multi-sig scripts with zero signatures.
This commit builds off the previous commit which fixed the execution of
multi-signature scripts with zero required signatures.
It introduces the concept of a "small int" which is one of OP_0 or OP_1 -
OP_16. All areas of code that deal with multi-sig transactions now make
use of these to ensure consistent handling.
This fixes a few issues surrounding multi-sig zero required signature
transactions included proper detection as a multi-sig script, signature
counting for script statistics, and
ok @owainga
Commit: a6cdb8b84452dfb0ae3f0951a529a45e9b78be77
https://github.com/btcsuite/btcd/commit/a6cdb8b84452dfb0ae3f0951a529a45e9b78be77
Author: Dave Collins <[email protected]>
Date: 2014-02-19 (Wed, 19 Feb 2014)
Changed paths:
M script_test.go
M test_coverage.txt
Log Message:
-----------
Add tests for multisig with zero required sigs.
Commit: b8dc1b66e5d37da87fc32868e66a784fa845ed4b
https://github.com/btcsuite/btcd/commit/b8dc1b66e5d37da87fc32868e66a784fa845ed4b
Author: Dave Collins <[email protected]>
Date: 2014-02-20 (Thu, 20 Feb 2014)
Changed paths:
A scriptbuilder.go
Log Message:
-----------
Add new ScriptBuilder for building custom scripts.
This commit adds a new ScriptBuilder interface that can be used to build
custom scripts. It currently is fairly basic, but it allows you to push
raw opcodes, ints, and data while respecting canonical encoding. These
primitives are sufficient to build any script.
This could be improved upon with quite a few things. One example would be
functions for certain opcodes that take properly typed parameters to make
it harder to create invalid scripts.
For now though, it is already quite useful since it handles all of the
opcode selection for canonical data pushes and integer encoding.
The initial discussion took place in #5.
Commit: 61d270957e5bc13934a17f2d7b4daee93d4f9bad
https://github.com/btcsuite/btcd/commit/61d270957e5bc13934a17f2d7b4daee93d4f9bad
Author: David Hill <[email protected]>
Date: 2014-02-20 (Thu, 20 Feb 2014)
Changed paths:
M script.go
M script_test.go
Log Message:
-----------
Add HasCanonicalPushes
Closes #6.
ok @davecgh
Commit: 50173b865bd352e1dd9c6308027127c750076196
https://github.com/btcsuite/btcd/commit/50173b865bd352e1dd9c6308027127c750076196
Author: Dave Collins <[email protected]>
Date: 2014-02-20 (Thu, 20 Feb 2014)
Changed paths:
M scriptbuilder.go
Log Message:
-----------
Allow push of 0 via new ScriptBuilder PushInt64.
Nothing was being pushed for 0 to the new ScriptBuilder due to the fact Go
big integers when set to 0 have no bytes.
Commit: 5a660e95f9ae9c0fd39a229783e733baa7558b82
https://github.com/btcsuite/btcd/commit/5a660e95f9ae9c0fd39a229783e733baa7558b82
Author: Dave Collins <[email protected]>
Date: 2014-02-20 (Thu, 20 Feb 2014)
Changed paths:
A scriptbuilder_test.go
M test_coverage.txt
Log Message:
-----------
Add 100% test coverage for new ScriptBuilder code.
Commit: cff7f9704b861e8d8039bc1b7042ee1ec7a8d3f1
https://github.com/btcsuite/btcd/commit/cff7f9704b861e8d8039bc1b7042ee1ec7a8d3f1
Author: Dave Collins <[email protected]>
Date: 2014-02-20 (Thu, 20 Feb 2014)
Changed paths:
M address.go
M script.go
M scriptbuilder.go
Log Message:
-----------
Fix a few comment typos.
Commit: 1566366346f8ebbf053b35edeb8e1dfa235bd3fc
https://github.com/btcsuite/btcd/commit/1566366346f8ebbf053b35edeb8e1dfa235bd3fc
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-02-20 (Thu, 20 Feb 2014)
Changed paths:
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
convert internal script generation to use ScriptBuilder.
Also, unexport the functions to generate script types. Everything should
(and is) be using PayToAddrScript() with an address type instead of
throwing bytes around.
discussed with #@davecgh
Commit: 5171cb803cf2efa82ad04d66c81530fe3d560660
https://github.com/btcsuite/btcd/commit/5171cb803cf2efa82ad04d66c81530fe3d560660
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-02-20 (Thu, 20 Feb 2014)
Changed paths:
M script.go
M script_test.go
M scriptbuilder.go
M scriptbuilder_test.go
M test_coverage.txt
Log Message:
-----------
Convert builder.Push* to builder.Add* we think this is clearer.
Also, shorter! Discussed with @davecgh.
Commit: 2b0b512a83acb2bdfa9766b7dc44b6f81cb89c02
https://github.com/btcsuite/btcd/commit/2b0b512a83acb2bdfa9766b7dc44b6f81cb89c02
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-02-20 (Thu, 20 Feb 2014)
Changed paths:
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
Add support for pay to pubkey addresses to PayToAddrScript
Based on some initial code from @davecgh, finished by me.
Commit: 88f3c73ad1c2501386cf90942d6c1ea5e3727870
https://github.com/btcsuite/btcd/commit/88f3c73ad1c2501386cf90942d6c1ea5e3727870
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-02-21 (Fri, 21 Feb 2014)
Changed paths:
M script.go
M script_test.go
M scriptbuilder.go
M test_coverage.txt
Log Message:
-----------
Add MultiSigScript to provide a canonical script for a multisig transaction.
Commit: 982f282e10ad7116448280c6d5c45084949d22a3
https://github.com/btcsuite/btcd/commit/982f282e10ad7116448280c6d5c45084949d22a3
Author: Dave Collins <[email protected]>
Date: 2014-02-21 (Fri, 21 Feb 2014)
Changed paths:
M script.go
M script_test.go
Log Message:
-----------
Go fmt.
Commit: da1fcc6dbd71fd14de90e77ce77895f26383c10f
https://github.com/btcsuite/btcd/commit/da1fcc6dbd71fd14de90e77ce77895f26383c10f
Author: Dave Collins <[email protected]>
Date: 2014-02-21 (Fri, 21 Feb 2014)
Changed paths:
M script.go
Log Message:
-----------
Tighten the check for pay-to-pubkey scripts.
This commit tightens the check for a pay-to-pubkey script by ensuring the
length of the pubkey is one of the two valid values of 33 or 65. This
mirrors the checks in the multisig script type check as well.
ok @owainga
Commit: 201d6651c983565947abf35f1af108ed98d06809
https://github.com/btcsuite/btcd/commit/201d6651c983565947abf35f1af108ed98d06809
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-13 (Thu, 13 Mar 2014)
Changed paths:
M script_test.go
Log Message:
-----------
Fix tests after IsForNet addition to btcutil.Address interface.
dhill pointed this out to me.
Commit: 8df0af32d605fb56350ab8d989eeab08a4c992d7
https://github.com/btcsuite/btcd/commit/8df0af32d605fb56350ab8d989eeab08a4c992d7
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M opcode.go
M script.go
Log Message:
-----------
Encountering OP_VERIF and OP_VERNOTIF in execution is always an error.
I honestly thought we already handled this, but some tests dhill is
working on shows that we didn't.
Commit: c1a6e47f38f2847b1cac108fd88252670b42e94c
https://github.com/btcsuite/btcd/commit/c1a6e47f38f2847b1cac108fd88252670b42e94c
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M script.go
Log Message:
-----------
Conditionals must not straddle two scripts.
Found by tests dhill is working on. We checked that ifs were closed at the end
of execution but not at script switching time, we now move this to just after
finishing a single script.
Commit: a5e7e9ebb669e09f2abb0783c635f4d340b11ff4
https://github.com/btcsuite/btcd/commit/a5e7e9ebb669e09f2abb0783c635f4d340b11ff4
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M opcode.go
M script.go
Log Message:
-----------
Disabled opcodes are `fail if pc passes' not fail if execute.
Detected by bitcoind negative tests.
Commit: c7d5102954bdfaf60b198281f12b9423df8fd5cb
https://github.com/btcsuite/btcd/commit/c7d5102954bdfaf60b198281f12b9423df8fd5cb
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M script.go
Log Message:
-----------
Alt stack should be purged between scripts.
Found by bitcoind negative scripts.
Commit: f80c3255a34cea396f9bc6bec273c71505aa0616
https://github.com/btcsuite/btcd/commit/f80c3255a34cea396f9bc6bec273c71505aa0616
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M opcode.go
M opcode_test.go
M stack.go
Log Message:
-----------
PopInt now guarantees that number will be 32 bit.
So remove later checks that need this.
Commit: 8beb0dec54550f434561e09b1bd9087c2633d2df
https://github.com/btcsuite/btcd/commit/8beb0dec54550f434561e09b1bd9087c2633d2df
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M opcode.go
M script.go
Log Message:
-----------
Make opcode.Exec run a bunch of unconditional checks
Add push length and number of operations to this to match bitcoind behaviour.
found that we differed here by their negative tests.
Commit: d6d755e411cadfcff143210741803f63da1a53bf
https://github.com/btcsuite/btcd/commit/d6d755e411cadfcff143210741803f63da1a53bf
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M opcode.go
M script.go
Log Message:
-----------
Always return reserved opcode for always-illegal ops.
Commit: dec16d7ff26f5145a0e573ddbd87df4108d104a8
https://github.com/btcsuite/btcd/commit/dec16d7ff26f5145a0e573ddbd87df4108d104a8
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M script.go
Log Message:
-----------
Enforce a combined max stack depth of 1000 after every opcode.
This limit is for the sum of main and alt stacks. Found by bitcoind
negative tests.
Commit: 42f6576b02636de92e44e206421ca4d0c622996b
https://github.com/btcsuite/btcd/commit/42f6576b02636de92e44e206421ca4d0c622996b
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M script.go
Log Message:
-----------
Enforce max script length of 10000.
Detected by bitcoind negative script tests. Note that this length is only for
*executing* scripts, this is why it is in NewScript.
Commit: 299dcc2fad071d33e5492af381f74dfc630363ae
https://github.com/btcsuite/btcd/commit/299dcc2fad071d33e5492af381f74dfc630363ae
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M script.go
Log Message:
-----------
PushDataN with a 0 length is valid, we were too tight here.
Found by bitcoind positive tests. (but of course that is noncanonical
anyway, it should be OP_0 ;).
Commit: 02ee7762e45257bcfde2343617649280d7c6af07
https://github.com/btcsuite/btcd/commit/02ee7762e45257bcfde2343617649280d7c6af07
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M scriptbuilder.go
Log Message:
-----------
AddData([]byte{}) is valid and should push empty to the stack.
Doing so is perfectly idiomatic. Fixes the last of the valid bitcoind
script tests. (by fixing the script parser :)
Commit: 9375c8dc481beab5af9c642f272f1006a71e74b6
https://github.com/btcsuite/btcd/commit/9375c8dc481beab5af9c642f272f1006a71e74b6
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-14 (Fri, 14 Mar 2014)
Changed paths:
M script.go
M test_coverage.txt
Log Message:
-----------
move data extraction fof OP_PUSHDATA into main function.
This allows us to centralise the error checking to simplify things a bit.
Commit: c8332cc9a7ecb05812e25a9b3bac565c9656f701
https://github.com/btcsuite/btcd/commit/c8332cc9a7ecb05812e25a9b3bac565c9656f701
Author: Dave Collins <[email protected]>
Date: 2014-03-17 (Mon, 17 Mar 2014)
Changed paths:
M script.go
M script_test.go
Log Message:
-----------
Correct num expected inputs calc for multisig.
This commit corrects the number of expected inputs for a multi-sig script
to include the additional item that is popped from the stack due to the
OP_CHECKMULTISIG consensus bug (which is required and properly performed).
Note this issue did NOT affect the consensus critical code and hence would
not cause a chain fork. It did however, cause standard p2sh multisig txns
to be rejected from the mempool as nonstandard.
The tx rejected as non-standard which prompted this was spotted by
@mbelshe on IRC.
ok @owainga
Commit: dab2a7cb0fec7269d88209736e9a09cf25d5415e
https://github.com/btcsuite/btcd/commit/dab2a7cb0fec7269d88209736e9a09cf25d5415e
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-17 (Mon, 17 Mar 2014)
Changed paths:
M opcode.go
Log Message:
-----------
Don't possibly dereference bad signatures in OP_CHECKMULTISIG.
We do all the preprocessing in one loop. Fixes a bug introduced a while ago to
handle invalid signatures. Found by more tests from bitcoind.
Commit: 76339baf6c9407b073828245e3458f4df35190ae
https://github.com/btcsuite/btcd/commit/76339baf6c9407b073828245e3458f4df35190ae
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-18 (Tue, 18 Mar 2014)
Changed paths:
M script.go
Log Message:
-----------
Make removeOpcodeByData in line with bitcoind behaviour.
It should remove the opcode and data is the data is contained within the data
pushed, not just if it is equal to it. Found by bitcoind tx tests.
Commit: 1b1fef73698c5aa6ad6f184d50f12daab74eed7f
https://github.com/btcsuite/btcd/commit/1b1fef73698c5aa6ad6f184d50f12daab74eed7f
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-18 (Tue, 18 Mar 2014)
Changed paths:
M script.go
M script_test.go
Log Message:
-----------
Make removeOpcodeByData only search canonical pushes.
Matches bitcoind behaviour. Pointed out by one of their tx_invalid tests.
Commit: 5f6de02eb86ba6aec6d9d90883c0bbd73756c7f8
https://github.com/btcsuite/btcd/commit/5f6de02eb86ba6aec6d9d90883c0bbd73756c7f8
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-19 (Wed, 19 Mar 2014)
Changed paths:
M script_test.go
Log Message:
-----------
use bytes.Repeat instead of my perlscript generated lists of zeros.
Pointed out by davec. I'd forgotten about it. Kills just over 10k lines
from the test file.
Commit: 8ec60d46784d0ff864947e8732b292a3ae510280
https://github.com/btcsuite/btcd/commit/8ec60d46784d0ff864947e8732b292a3ae510280
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-03-19 (Wed, 19 Mar 2014)
Changed paths:
A data/LICENSE
A data/script_invalid.json
A data/script_valid.json
A data/tx_invalid.json
A data/tx_valid.json
M internal_test.go
M test_coverage.txt
Log Message:
-----------
Quick and dirty tests harnesses using some bitcoind test data.
Both the script tests (positive and negative) and tx texts (ditto) are
present. Some of the tx tests in the negative section have been
replaced by a comment line explaining why that test is elided, to add in
diffing. The reasons were always that they test things handled by other
parts of the btcd stack (normally chain). For example MAX_MONEY, number
of outputs, coinbase sizes etc.
Much of the inital test logic from @dajohi using hand transcribed tables
for selected tests. The json parsers, script format parser and a lot of
cleaning up/bugfixing from your truly. @davecgh had some input too.
Commit: f529a37123efa587f90c1147c4d847fcd077b5ab
https://github.com/btcsuite/btcd/commit/f529a37123efa587f90c1147c4d847fcd077b5ab
Author: Dave Collins <[email protected]>
Date: 2014-04-03 (Thu, 03 Apr 2014)
Changed paths:
M data/script_invalid.json
M test_coverage.txt
Log Message:
-----------
Add tests for doing math on 5-byte ints.
This commit addes a couple of tests to ensure performing math operations
on a 5-byte integer, even if the result is a 4-byte integer, is considered
invalid.
Commit: 4fce6d1476ea32bafb5d535f0e68910ca9524705
https://github.com/btcsuite/btcd/commit/4fce6d1476ea32bafb5d535f0e68910ca9524705
Author: Dave Collins <[email protected]>
Date: 2014-04-03 (Thu, 03 Apr 2014)
Changed paths:
M data/script_invalid.json
M data/script_valid.json
Log Message:
-----------
Sync latest script tests to bitcoind test suite.
Commit: 03dd134305b49b2f117b2d66d8229980715087fe
https://github.com/btcsuite/btcd/commit/03dd134305b49b2f117b2d66d8229980715087fe
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-04-09 (Wed, 09 Apr 2014)
Changed paths:
M opcode.go
Log Message:
-----------
adapt for btcec changes.
Commit: 1240483592b478486af97afe94868b7770e21602
https://github.com/btcsuite/btcd/commit/1240483592b478486af97afe94868b7770e21602
Author: David Hill <[email protected]>
Date: 2014-04-11 (Fri, 11 Apr 2014)
Changed paths:
M script_test.go
Log Message:
-----------
gofmt
Commit: 76e8fa9766e30370cb242f89b944e131d8e40e56
https://github.com/btcsuite/btcd/commit/76e8fa9766e30370cb242f89b944e131d8e40e56
Author: David Hill <[email protected]>
Date: 2014-05-01 (Thu, 01 May 2014)
Changed paths:
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
Reduce OP_RETURN standard relay bytes to 40.
This matches commit 8175c790eb12f0b0ca3197895a6d1d479b340b67 of
the reference software.
Commit: 6e2ba386dd36cd3f17be86d898337f4db82ce6ef
https://github.com/btcsuite/btcd/commit/6e2ba386dd36cd3f17be86d898337f4db82ce6ef
Author: Owain G. Ainsworth <[email protected]>
Date: 2014-05-07 (Wed, 07 May 2014)
Changed paths:
M internal_test.go
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
Add an entypoint to sign and verify a transaction input.
This handles merging in of previous scripts, also. Add tests for the important
paths. ok @davecgh
Commit: 27e1ad758bb0a88347436011624e2d7ad459f0fb
https://github.com/btcsuite/btcd/commit/27e1ad758bb0a88347436011624e2d7ad459f0fb
Author: David Hill <[email protected]>
Date: 2014-05-20 (Tue, 20 May 2014)
Changed paths:
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
Add new function PushedData.
PushedData returns an array of byte slices containing any pushed data
found in the passed script. This includes OP_0, but not OP_1 - OP_16.
help from and ok @owainga
Commit: be325b9d9c69f330d32143a3915d665e65b0066d
https://github.com/btcsuite/btcd/commit/be325b9d9c69f330d32143a3915d665e65b0066d
Author: Josh Rickmar <[email protected]>
Date: 2014-05-27 (Tue, 27 May 2014)
Changed paths:
M address.go
M address_test.go
M script.go
M script_test.go
M test_coverage.txt
Log Message:
-----------
Update API for btcnet and btcutil changes.
ok @davecgh
Commit: a591c7ec03530aa80ebcb63bc1808708eabddc22
https://github.com/btcsuite/btcd/commit/a591c7ec03530aa80ebcb63bc1808708eabddc22
Author: David Hill <[email protected]>
Date: 2014-05-29 (Thu, 29 May 2014)
Changed paths:
M opcode.go
M script.go
Log Message:
-----------
Add new ScriptFlag ScriptStrictMultiSig.
ScriptStrictMultiSig verifies that the stack item used by CHECKMULTISIG
is zero length.
Commit: e560b6d964bf0278df3fce86ec8baf11b6cf73db
https://github.com/btcsuite/btcd/commit/e560b6d964bf0278df3fce86ec8baf11b6cf73db
Author: David Hill <[email protected]>
Date: 2014-05-29 (Thu, 29 May 2014)
Changed paths:
M data/script_invalid.json
M data/script_valid.json
M data/tx_invalid.json
M data/tx_valid.json
M internal_test.go
M test_coverage.txt
Log Message:
-----------
sync bitcoind test data.
Commit: 7d228846bd70dc452fee68fdf68d0e7b739f4be6
https://github.com/btcsuite/btcd/commit/7d228846bd70dc452fee68fdf68d0e7b739f4be6
Author: David Hill <[email protected]>
Date: 2014-06-13 (Fri, 13 Jun 2014)
Changed paths:
M data/tx_valid.json
Log Message:
-----------
sync tx_valid.json test data.
Commit: 79b6e51dff2d8250bfb3b6f8b1b9271f4ec3eb7e
https://github.com/btcsuite/btcd/commit/79b6e51dff2d8250bfb3b6f8b1b9271f4ec3eb7e
Author: Dave Collins <[email protected]>
Date: 2014-07-02 (Wed, 02 Jul 2014)
Changed paths:
M script_test.go
Log Message:
-----------
Update tests for recent btcutil.Address API change.
Commit: 5beafbd2d8be535c6a8f439b08d1c970da25b7bc
https://github.com/btcsuite/btcd/commit/5beafbd2d8be535c6a8f439b08d1c970da25b7bc
Author: Dave Collins <[email protected]>
Date: 2014-07-02 (Wed, 02 Jul 2014)
Changed paths:
M address_test.go
M internal_test.go
M log.go
M opcode.go
M opcode_test.go
M script.go
M script_test.go
M scriptbuilder_test.go
M stack_test.go
Log Message:
-----------
goimports -w .
Commit: 3c2ae358b429ce6942e4aae94be3f12512b7f85b
https://github.com/btcsuite/btcd/commit/3c2ae358b429ce6942e4aae94be3f12512b7f85b
Author: Dave Collins <[email protected]>
Date: 2014-07-08 (Tue, 08 Jul 2014)
Changed paths:
M README.md
Log Message:
-----------
Add godoc reference badge to README.md.
Commit: abafe9678bd1025b963036c9675285de40aa385a
https://github.com/btcsuite/btcd/commit/abafe9678bd1025b963036c9675285de40aa385a
Author: Dave Collins <[email protected]>
Date: 2014-07-08 (Tue, 08 Jul 2014)
Changed paths:
M README.md
M doc.go
A example_test.go
Log Message:
-----------
Use testable example and update doc.go README.md.
This commit adds an example test file so it integrates nicely with Go's
example tooling.
This allows the example output to be tested as a part of running the
normal Go tests to help ensure it doesn't get out of date with the code.
It is also nice to have the example in one place rather than repeating it
in doc.go and README.md.
Links and information about the example have been included in README.md in
place of the example.
Commit: 631c7850ecbd02c1ddfca6580ee083cc3085a315
https://github.com/btcsuite/btcd/commit/631c7850ecbd02c1ddfca6580ee083cc3085a315
Author: Dave Collins <[email protected]>
Date: 2014-07-08 (Tue, 08 Jul 2014)
Changed paths:
M README.md
Log Message:
-----------
Correct example link in README.md.
Commit: 95167204d9345662c93e36a8f067818ff6cb448d
https://github.com/btcsuite/btcd/commit/95167204d9345662c93e36a8f067818ff6cb448d
Author: Dave Collins <[email protected]>
Date: 2014-07-08 (Tue, 08 Jul 2014)
Changed paths:
M README.md
M example_test.go
Log Message:
-----------
Add ExtractPkScriptAddrs examples.
Commit: 24c3873956a591f99c70973b3771cf0e75d97874
https://github.com/btcsuite/btcd/commit/24c3873956a591f99c70973b3771cf0e75d97874
Author: Michalis Kargakis <[email protected]>
Date: 2014-07-31 (Thu, 31 Jul 2014)
Changed paths:
A log_test.go
M test_coverage.txt
Log Message:
-----------
Add log testing
8/10 of SetLogWriter tested
Commit: ef0ca7dff570d2c9c55d6480686c3b14130861f6
https://github.com/btcsuite/btcd/commit/ef0ca7dff570d2c9c55d6480686c3b14130861f6
Author: David Hill <[email protected]>
Date: 2014-08-01 (Fri, 01 Aug 2014)
Changed paths:
M data/script_invalid.json
M data/script_valid.json
M opcode.go
Log Message:
-----------
sync bitcoind script tests
Commit: 55ad967b4d6699b511b7d941a7a192536a8c56aa
https://github.com/btcsuite/btcd/commit/55ad967b4d6699b511b7d941a7a192536a8c56aa
Author: Michalis Kargakis <[email protected]>
Date: 2014-08-03 (Sun, 03 Aug 2014)
Changed paths:
M log_test.go
M test_coverage.txt
Log Message:
-----------
Complete SetLogWriter testing
Commit: 6ae916bd3704a7d0f74b833860768a22c27c20c4
https://github.com/btcsuite/btcd/commit/6ae916bd3704a7d0f74b833860768a22c27c20c4
Author: Michalis Kargakis <[email protected]>
Date: 2014-08-08 (Fri, 08 Aug 2014)
Changed paths:
M script_test.go
M test_coverage.txt
Log Message:
-----------
More tests
Tests for IsPushOnlyScript, HasCanonicalPushes, and CalcMultiSigStats
Commit: 95cd1b97fa823f2e8d5f481cdaab149deb356ff1
https://github.com/btcsuite/btcd/commit/95cd1b97fa823f2e8d5f481cdaab149deb356ff1
Author: Dave Collins <[email protected]>
Date: 2014-08-13 (Wed, 13 Aug 2014)
Changed paths:
M opcode.go
Log Message:
-----------
Make the OP_FALSE constant untyped.
This makes it consistent with the rest of the opcode constants.
Commit: da080e1598fabe49a11c60532ced743c76529a8f
https://github.com/btcsuite/btcd/commit/da080e1598fabe49a11c60532ced743c76529a8f
Author: Jonathan Gillham <[email protected]>
Date: 2014-08-25 (Mon, 25 Aug 2014)
Changed paths:
M script.go
Log Message:
-----------
Changed privkey to privKey for consistency.
Commit: 516db23576aef5476a76cb735592f12fe8c905b8
https://github.com/btcsuite/btcd/commit/516db23576aef5476a76cb735592f12fe8c905b8
Author: Jonathan Gillham <[email protected]>
Date: 2014-08-25 (Mon, 25 Aug 2014)
Changed paths:
M script.go
M script_test.go
Log Message:
-----------
Replaced privkey in entire codebase.
Commit: 2803ea17c2a7ec5b806b9085c2a7949cee5355f1
https://github.com/btcsuite/btcd/commit/2803ea17c2a7ec5b806b9085c2a7949cee5355f1
Author: David Hill <[email protected]>
Date: 2014-08-29 (Fri, 29 Aug 2014)
Changed paths:
M opcode.go
M opcode_test.go
M script.go
M stack.go
M test_coverage.txt
Log Message:
-----------
Remove the use of go-spew.
Commit: edb006c11c5a25a8e2187435ef4ff61f0478442f
https://github.com/btcsuite/btcd/commit/edb006c11c5a25a8e2187435ef4ff61f0478442f
Author: Jonathan Gillham <[email protected]>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M internal_test.go
M opcode_test.go
M script_test.go
Log Message:
-----------
Changed TxIn.PreviousOutpoint to TxIn.PreviousOutPoint after btcwire API
change.
Commit: b89cabfb291ed60d64679f44626c13b0c4481af2
https://github.com/btcsuite/btcd/commit/b89cabfb291ed60d64679f44626c13b0c4481af2
Author: kac- <[email protected]>
Date: 2014-10-05 (Sun, 05 Oct 2014)
Changed paths:
M script.go
Log Message:
-----------
comment:script.go: ScriptDB->KeyDB
Commit: 9f47e9369c09fbc98f5e20bb5128321f4ba0d080
https://github.com/btcsuite/btcd/commit/9f47e9369c09fbc98f5e20bb5128321f4ba0d080
Author: Jonathan Gillham <[email protected]>
Date: 2014-10-10 (Fri, 10 Oct 2014)
Changed paths:
M script.go
Log Message:
-----------
Fixed SignTxOutput doc spelling error.
Commit: 37ad7042b6f1f66566115a5ac196b6515b0203a9
https://github.com/btcsuite/btcd/commit/37ad7042b6f1f66566115a5ac196b6515b0203a9
Author: Jonathan Gillham <[email protected]>
Date: 2014-10-11 (Sat, 11 Oct 2014)
Changed paths:
M opcode.go
M script.go
M script_test.go
Log Message:
-----------
Made hashType typed as SigHashType.
Commit: c0c3d860d693c9d477c9d7c2ef8784c4b7b4c041
https://github.com/btcsuite/btcd/commit/c0c3d860d693c9d477c9d7c2ef8784c4b7b4c041
Author: Dave Collins <[email protected]>
Date: 2014-10-12 (Sun, 12 Oct 2014)
Changed paths:
M doc.go
M internal_test.go
M opcode.go
M opcode_test.go
M script.go
M script_test.go
M stack.go
M stack_test.go
Log Message:
-----------
Convert all StackErrX to ErrStackX.
This commit changes all stack errors from the form of StackErrX to
ErrStackX which is the expected form for standard Go code.
Commit: ce0a3343294098214c044e1eb6d91379cfabc97f
https://github.com/btcsuite/btcd/commit/ce0a3343294098214c044e1eb6d91379cfabc97f
Author: Dave Collins <[email protected]>
Date: 2014-10-12 (Sun, 12 Oct 2014)
Changed paths:
M script.go
Log Message:
-----------
Comment ScriptInfo struct according to standards.
Found by golint.
Commit: d5cc72dc278d87ec4c348af7f80cba17aa992ffc
https://github.com/btcsuite/btcd/commit/d5cc72dc278d87ec4c348af7f80cba17aa992ffc
Author: Jimmy Song <[email protected]>
Date: 2014-10-12 (Sun, 12 Oct 2014)
Changed paths:
M opcode.go
M script.go
M script_test.go
Log Message:
-----------
use btcec structs instead of ecdsa structs
Commit: a61c0f06cfde0909e99950e9f41d88a4d69e6aa2
https://github.com/btcsuite/btcd/commit/a61c0f06cfde0909e99950e9f41d88a4d69e6aa2
Author: Jonathan Gillham <[email protected]>
Date: 2014-10-13 (Mon, 13 Oct 2014)
Changed paths:
M script.go
Log Message:
-----------
Removed unnecessary signTxOutputCustomReader.
Commit: def35f2cd4ec47e2ae5e0edd2f49ff078ba22af2
https://github.com/btcsuite/btcd/commit/def35f2cd4ec47e2ae5e0edd2f49ff078ba22af2
Author: David Hill <[email protected]>
Date: 2014-12-08 (Mon, 08 Dec 2014)
Changed paths:
M data/script_invalid.json
M data/script_valid.json
M internal_test.go
Log Message:
-----------
Sync Bitcoin Core tests.
Commit: bca3d5ba7beeaf77c6b2e4d013fb08ab371972c0
https://github.com/btcsuite/btcd/commit/bca3d5ba7beeaf77c6b2e4d013fb08ab371972c0
Author: Josh Rickmar <[email protected]>
Date: 2014-12-11 (Thu, 11 Dec 2014)
Changed paths:
M opcode.go
Log Message:
-----------
Switch to new subrepo import paths.
Commit: 45e7fe103f6bd93d31ced7d2fecb2068b6245dd9
https://github.com/btcsuite/btcd/commit/45e7fe103f6bd93d31ced7d2fecb2068b6245dd9
Author: David Hill <[email protected]>
Date: 2014-12-19 (Fri, 19 Dec 2014)
Changed paths:
M data/tx_invalid.json
M data/tx_valid.json
M test_coverage.txt
Log Message:
-----------
Sync TX tests with Bitcoin Core.
Commit: 2f902a5880b62e97cc0f34f2ade49c3692ba3d28
https://github.com/btcsuite/btcd/commit/2f902a5880b62e97cc0f34f2ade49c3692ba3d28
Author: Guilherme Salgado <[email protected]>
Date: 2014-12-20 (Sat, 20 Dec 2014)
Changed paths:
M script.go
Log Message:
-----------
Rename signTxOutput to RawTxInSignature
Commit: 8e1973d865c981f6dee0fad06af86cdcd3f83fa8
https://github.com/btcsuite/btcd/commit/8e1973d865c981f6dee0fad06af86cdcd3f83fa8
Author: Dave Collins <[email protected]>
Date: 2014-12-20 (Sat, 20 Dec 2014)
Changed paths:
M internal_test.go
Log Message:
-----------
Correct a couple of typos spotted while reviewing.
Commit: c4f1ed69d28794c4b0e5034ea402a0d9a148a509
https://github.com/btcsuite/btcd/commit/c4f1ed69d28794c4b0e5034ea402a0d9a148a509
Author: Dave Collins <[email protected]>
Date: 2015-01-15 (Thu, 15 Jan 2015)
Changed paths:
M address.go
M address_test.go
M example_test.go
M internal_test.go
M script.go
M script_test.go
Log Message:
-----------
Update btcutil import paths to new location.
Commit: c112c004cffe32b38591c231239dc8c7f5bc3b13
https://github.com/btcsuite/btcd/commit/c112c004cffe32b38591c231239dc8c7f5bc3b13
Author: Dave Collins <[email protected]>
Date: 2015-01-16 (Fri, 16 Jan 2015)
Changed paths:
M log_test.go
Log Message:
-----------
Update log test for upstream seelog changes.
Commit: 6dcc6e5e66ec6a345b59bc8f2262254c106ec7e2
https://github.com/btcsuite/btcd/commit/6dcc6e5e66ec6a345b59bc8f2262254c106ec7e2
Author: Dave Collins <[email protected]>
Date: 2015-01-16 (Fri, 16 Jan 2015)
Changed paths:
M opcode.go
Log Message:
-----------
Update fastsha256 import paths to new location.
Commit: 6efda349daafa519b91246065acc9ec2ca7cecb9
https://github.com/btcsuite/btcd/commit/6efda349daafa519b91246065acc9ec2ca7cecb9
Author: Dave Collins <[email protected]>
Date: 2015-01-16 (Fri, 16 Jan 2015)
Changed paths:
M log.go
Log Message:
-----------
Update btclog import paths to new location.
Commit: 5c52f67b4f3a078d4ee25a44e79287f391c67062
https://github.com/btcsuite/btcd/commit/5c52f67b4f3a078d4ee25a44e79287f391c67062
Author: Dave Collins <[email protected]>
Date: 2015-01-16 (Fri, 16 Jan 2015)
Changed paths:
M internal_test.go
M opcode.go
M opcode_test.go
M script.go
M script_test.go
Log Message:
-----------
Update btcwire import paths to new location.
Commit: f513a56a62016263eb4f6ad51e5d42c76b3aa753
https://github.com/btcsuite/btcd/commit/f513a56a62016263eb4f6ad51e5d42c76b3aa753
Author: Dave Collins <[email protected]>
Date: 2015-01-16 (Fri, 16 Jan 2015)
Changed paths:
M address.go
M address_test.go
M example_test.go
M script.go
M script_test.go
Log Message:
-----------
Update btcnet import paths to new location.
Commit: eb02adfada569144c6a8c4cce1aeefcc269d3acc
https://github.com/btcsuite/btcd/commit/eb02adfada569144c6a8c4cce1aeefcc269d3acc
Author: Dave Collins <[email protected]>
Date: 2015-01-16 (Fri, 16 Jan 2015)
Changed paths:
M opcode.go
M script.go
M script_test.go
Log Message:
-----------
Update btcec import paths to new location.
Commit: 251d0fc6c47de9a879a77061d311e7dd77804034
https://github.com/btcsuite/btcd/commit/251d0fc6c47de9a879a77061d311e7dd77804034
Author: Dave Collins <[email protected]>
Date: 2015-01-16 (Fri, 16 Jan 2015)
Changed paths:
M README.md
M address_test.go
M example_test.go
M log_test.go
M opcode_test.go
M script_test.go
M scriptbuilder_test.go
M stack_test.go
Log Message:
-----------
Update btcscript import paths to new location.
Commit: af5cbe4b4f0665a2c79619e51b40e17c33b1889c
https://github.com/btcsuite/btcd/commit/af5cbe4b4f0665a2c79619e51b40e17c33b1889c
Author: Dave Collins <[email protected]>
Date: 2015-01-28 (Wed, 28 Jan 2015)
Changed paths:
M internal_test.go
M script.go
M script_test.go
M scriptbuilder.go
M scriptbuilder_test.go
Log Message:
-----------
Update script builder for BIP0062 and enforce limits.
BIP0062 defines specific rules and canonical encodings for data pushes.
The existing script builder code already conformed to all but one of the
canonical data push rules that was added after it was originally
implemented (adding a single byte of 0x81 must be converted to
OP_1NEGATE). This commit implements that case and expands the existing
tests to explicitly cover all cases mentioned in BIP0062.
In addition, as a part of this change, the AddData function has been
modified so that any attempt to push more than the maximum script element
size bytes (520) in one push or any pushes the would cause the script to
exceed the maximum script bytes allowed by the script engine (10000) will
result in the final call to the Script function to only return the script
up to the point of the first error along with the error. This change
should have little effect on existing callers since they are almost
positively not creating scripts which violate these rules as they could
never be executed, however it does mean they need to check the new error
return.
Since the regression tests intentionally need to be able to exceed that
limit, a new function named AddFullData has been added which does not
enforce the limits, but still provides canonical encoding of the pushed
data.
Note that this commit does not affect consensus rules nor modify the
script engine.
Also, the tests have been marked so they can run in parallel.
Commit: f513518b4f1f22432999d45598d1d26a76ced12d
https://github.com/btcsuite/btcd/commit/f513518b4f1f22432999d45598d1d26a76ced12d
Author: David Hill <[email protected]>
Date: 2015-01-29 (Thu, 29 Jan 2015)
Changed paths:
M data/script_invalid.json
M data/script_valid.json
M internal_test.go
M opcode.go
M script.go
M test_coverage.txt
Log Message:
-----------
Discourage NOPs reserved for soft-fork upgrades
NOP1 through NOP10 are reserved for future soft-fork upgrades. When
such an upgrade occurs, the NOP argument will then require verification.
Rejecting transactions that contain these NOPs into the mempool will
discourage those transactions from being mined elsewhere and ensure
btcd will never mine such transactions. This prevents now
invalid scripts (according to the majority of hashing power) even if the
client has not yet upgraded.
Non-executed upgradable NOPs are still allowed as they will still be
valid post-upgrade.
Mimics Bitcoin Core commit 03914234b3c9c35d66b51d580fe727a0707394ca
Commit: 8e6abdb1257ccef62e5d05e4bcd64f51f8745082
https://github.com/btcsuite/btcd/commit/8e6abdb1257ccef62e5d05e4bcd64f51f8745082
Author: Dave Collins <[email protected]>
Date: 2015-01-29 (Thu, 29 Jan 2015)
Changed paths:
M opcode_test.go
M script_test.go
M stack_test.go
Log Message:
-----------
Make several of the reg tests more consistent.
This commit modifies various regression tests to make them more consistent
with other tests throughout the code base.
Also, it allows of all the tests to run in parallel.
Commit: d7dbe25d9713a39f59980094ee20aff050f39f6b
https://github.com/btcsuite/btcd/commit/d7dbe25d9713a39f59980094ee20aff050f39f6b
Author: Dave Collins <[email protected]>
Date: 2015-01-29 (Thu, 29 Jan 2015)
Changed paths:
M script_test.go
M scriptbuilder_test.go
Log Message:
-----------
Fix test error verbs found by go vet in the tests.
Commit: 115cea21096b2e4464e2f5ae58f1d35cc9a5edcd
https://github.com/btcsuite/btcd/commit/115cea21096b2e4464e2f5ae58f1d35cc9a5edcd
Author: David Hill <[email protected]>
Date: 2015-01-29 (Thu, 29 Jan 2015)
Changed paths:
M data/script_invalid.json
M data/script_valid.json
M internal_test.go
M script.go
M test_coverage.txt
Log Message:
-----------
Add new flag ScriptVerifySigPushOnly.
The ScriptVerifySigPushOnly flag enforces signature scripts to
only contain pushed data. This is rule 2 of BIP0062.
Mimics Bitcoin Core commit d752ba86c1872f64a4641cf77008826d32bde65f
Commit: cbda0648425e58c2bf0db97f5dd7a74da7accf5e
https://github.com/btcsuite/btcd/commit/cbda0648425e58c2bf0db97f5dd7a74da7accf5e
Author: Dave Collins <[email protected]>
Date: 2015-01-30 (Fri, 30 Jan 2015)
Changed paths:
R .gitignore
R .travis.yml
R LICENSE
R README.md
R address.go
R address_test.go
R cov_report.sh
R data/LICENSE
R data/script_invalid.json
R data/script_valid.json
R data/tx_invalid.json
R data/tx_valid.json
R doc.go
R example_test.go
R internal_test.go
R log.go
R log_test.go
R opcode.go
R opcode_test.go
R script.go
R script_test.go
R scriptbuilder.go
R scriptbuilder_test.go
R stack.go
R stack_test.go
R test_coverage.txt
A txscript/README.md
A txscript/address.go
A txscript/address_test.go
A txscript/data/LICENSE
A txscript/data/script_invalid.json
A txscript/data/script_valid.json
A txscript/data/tx_invalid.json
A txscript/data/tx_valid.json
A txscript/doc.go
A txscript/example_test.go
A txscript/internal_test.go
A txscript/log.go
A txscript/log_test.go
A txscript/opcode.go
A txscript/opcode_test.go
A txscript/script.go
A txscript/script_test.go
A txscript/scriptbuilder.go
A txscript/scriptbuilder_test.go
A txscript/stack.go
A txscript/stack_test.go
Log Message:
-----------
Import btcscript repo into txscript directory.
This commit contains the entire btcscript repository along with several
changes needed to move all of the files into the txscript directory in
order to prepare it for merging. This does NOT update btcd or any of the
other packages to use the new location as that will be done separately.
- All import paths in the old btcscript test files have been changed to the
new location
- All references to btcscript as the package name have been chagned to
txscript
This is ongoing work toward #214.
Commit: be11f23e14af3530be22c735c6bca782001e09d4
https://github.com/btcsuite/btcd/commit/be11f23e14af3530be22c735c6bca782001e09d4
Author: Dave Collins <[email protected]>
Date: 2015-01-30 (Fri, 30 Jan 2015)
Changed paths:
A txscript/README.md
A txscript/address.go
A txscript/address_test.go
A txscript/data/LICENSE
A txscript/data/script_invalid.json
A txscript/data/script_valid.json
A txscript/data/tx_invalid.json
A txscript/data/tx_valid.json
A txscript/doc.go
A txscript/example_test.go
A txscript/internal_test.go
A txscript/log.go
A txscript/log_test.go
A txscript/opcode.go
A txscript/opcode_test.go
A txscript/script.go
A txscript/script_test.go
A txscript/scriptbuilder.go
A txscript/scriptbuilder_test.go
A txscript/stack.go
A txscript/stack_test.go
Log Message:
-----------
Merge btcscript repo into txscript directory.
Compare: https://github.com/btcsuite/btcd/compare/7180e2a92b99...be11f23e14af
