Branch: refs/heads/master
Home: https://github.com/btcsuite/btcwallet
Commit: 4f6edce6dc12f68991bb29b8b4ef68a75b84788d
https://github.com/btcsuite/btcwallet/commit/4f6edce6dc12f68991bb29b8b4ef68a75b84788d
Author: Josh Rickmar <[email protected]>
Date: 2015-10-16 (Fri, 16 Oct 2015)
Changed paths:
M rpcserver.go
Log Message:
-----------
Fix signmessage RPC to match Core.
AFAICT this function has never worked correctly due to the hash being
signed not matching the hash created by Core. Core wallet writes
serialized strings to a double-sha256 hashing stream, while we were
using string concatination. This produced different messages since
the message before hashing did not include compact integers (called
varints in btcsuite code) preceding each string with the string
length.
Tested by creating signed messages from btcwallet and verifying them
with Bitcoin-Qt, as well as creating signatures from Bitcoin-Qt and
verifying them with btcwallet.
Fixes #323.
