On Wed, Oct 17, 2012 at 08:50:30PM -0700, David E. Wheeler wrote: [limitdbs] >> Verdict: placeholder. > > So, it does not actually do anything now? Should I create an issue for it?
No need. It only becomes useful when/if we go to multiple kids. So I suppose since we hav a good upgrade system we could simply take it out for now. > You've noticed all the issues I've created, I assume. :-) Yep. Might want put this somewhere in the docs: > http://github.com/bucardo/bucardo/issues [do_listen] > Did it used to do something different? Should I make it an alias for ping? I've no idea. I say keep 'ping' and remove do_listen, with no alias. Or nuke ping and keep do_listen, if you think it's a better name. I don't think either one is hard-coded into people's brains enough to require an alias. > Well, since 5.0 is so close to done, perhaps we shouldn't worry about > getting rid of the source vs. target split just now, yes? In which case, > does the makedelta stuff need to be hooked back up? Yes, it should. But source and target really no longer applies in the world of b5. Probably the easiest thing to do at the moment is to make a single sync-level boolean for makedelta, and expand it in a future version. The expansion will allow setting things at the db+sync level, which means a new internal map table to tie the two together, plus a lot of interface/doc fiddling. > >> The `overdue` and `expired` params appear to be no-ops. True? > > > > No - they are used by bucardo_report and especially for Nagios tie-ins. > > Okay? What for? What do they mean? They are the amount of time before a warning and critical are given. (Or however your monitoring system chooses to interpret it). In other words, if a sync has not run in 6 minutes, and overdue is set to '5 minutes', the number of stale syncs is incremented by one and that sync is reported in the special Nagios section of bucardo-report. Check out that code for more details. > >> What is the `track_rates` parameter for? I see some stuff about > >> tracking rates, but don't understand what might be tracked or why. > > > > It's tracking how long a sync run takes. I'm not sure how useful it > > still is. If it's a lot of trouble to get working right in bucardo5, > > I say we take a quick poll to see if anyone is using it and nuke it. > > Is Bucardo currently logging that information somewhere? Summary sync information is logged to the syncrun table, but if track_rates is on, much more detail is logged, via the bucardo_rate table. Again, I am fine with taking this out for now. > Yeah, but the code for customselect says to use customcols instead. > customcols > seems to implicitly turn on customselect, no? customselect just needs to go away completely. See line 5793 of Bucardo.pm, for example. :) -- Greg Sabino Mullane [email protected] End Point Corporation PGP Key: 0x14964AC8
pgpWqz8ftMugI.pgp
Description: PGP signature
_______________________________________________ Bucardo-general mailing list [email protected] https://mail.endcrypt.com/mailman/listinfo/bucardo-general
