Hi, Tassilo Horn <[email protected]> wrote:
> Thanks, good catch. I've applied this patch. However, it's quite on > the borderline to "not so tiny patch". So would you please be willing > to sign a copyright assignment so that we can easily take your > contributions in the future? OK, I will see that. Had forgotten about this one... (will think about writing ChangeLog entries, too, hello Mosè! ;-) > That patch doesn't apply for me failing in the tex.el hunk. Did you apply auctex_TeX-expand-list.patch from my previous bug report (<[email protected]>, "Bug in the expansion of %' in TeX-expand-list")? It does work here: /tmp % tar -xzf ~/src-pastouche/auctex-11.87.tar.gz 405 flo@zita /tmp % cd auctex-11.87 406 flo@zita /tmp/auctex-11.87 % patch -p1 <~/tmp/auctex_TeX-expand-list.patch 407 flo@zita patching file tex.el /tmp/auctex-11.87 % patch -p1 <~/tmp/auctex_TeX-command-expand_filename_expansion_bug.patch patching file tex-buf.el /tmp/auctex-11.87 % patch -p1 <~/tmp/auctex_TeX-command-expand_readability_improvement.patch patching file tex-buf.el patching file tex.el /tmp/auctex-11.87 % > And I'm not > sure if its a good idea to rename the function parameter. If you'd > rename the let-bound `file', then you wouldn't need to change the > `TeX-expand-list' entry, right? You can't do that, because this is precisely the binding used by all other `TeX-expand-list' entries, and the documented one that users are likely to be relying upon... In AUCTeX 11.87 without any patch, the only place from `TeX-command-expand', including of course the expansion of `TeX-expand-list', where the 'file' binding used is *not* the one created by let, is the place in tex-buf.el where my patch changes 'file' into 'filefunc' for clarity: (let (pat pos entry TeX-command-text TeX-command-pos (file `(lambda (&rest args) (shell-quote-argument (concat (and (stringp TeX-command-pos) TeX-command-pos) --> (apply ',file args) (and (stringp TeX-command-pos) TeX-command-pos))))) case-fold-search string expansion arguments) In this place, 'file' is taken from the corresponding function argument, which is why I renamed both. In all other places, the binding used by Emacs comes from the let AFAICT. However, as I tried to explain in the bug report, there is one of these places where the correct thing to do IMHO would be to use the binding from the `TeX-command-expand' function arguments: this is in the expansion of %' as defined in `TeX-expand-list'. This is why my patch changes 'file' into 'filefunc' there too. Bye, -- Florent _______________________________________________ bug-auctex mailing list [email protected] https://lists.gnu.org/mailman/listinfo/bug-auctex
