> thanks for the patch, I applied it with minor changes (XEmacs doesn't > have `display-graphic-p', I kept the old test).
Alright, but there is a problem with the current test. Because getenv searches in process-environment by default, if Emacs is run with --daemon from outside the user's X scope, it will stay false (as intended), but if it is run from an X screen, and then an emacsclient is spawned via, e.g., an ssh (-x) connection it will show up evince on the server. So getenv should receive the current frame as an extra parameter. That may just be corrected by (getenv "DISPLAY" (selected-frame)). Thanks for including the patch anyway. I've uploaded my repo to contain such additional patch. Here it is: https://github.com/ssaavedra/auctex/commit/c725ac694334f9c9b5694ff17a8945223e128972.patch Thanks. > 2015-11-10 17:46 GMT+01:00 Santiago Saavedra <[email protected]>: >> Sorry, I changed the commit, because there was a bug in the >> implementation. Here is the updated request. >> >> >> The following changes since commit 0c9b98aeeeb612c04824140627cb5e86a763dcf9: >> >> Fix compatibility with XEmacs in tex-info.el (2015-11-09 22:45:20 +0100) >> >> are available in the git repository at: >> >> https://github.com/ssaavedra/auctex.git >> >> for you to fetch changes up to 1a79e7ef99c2934e0cb9b1ab66098727e3833540: > > For the future, a real patch is easier to handle, at least a direct > link to the patch[1]. Alright, I just pasted you the output of git request-pull, I wasn't sure on how was the best way for you :-) > Luckily it was a minor change and mainly a reorganization of existing > code, but should you want to send further patches you would need to > assign the copyright to FSF in order for them to be installed in > AUCTeX ;-) I have no problem assigning the copyright of AUCTeX contributions to FSF, so please tell me in this regard what would I need to do. But any of these patches are small enough, I think. -- Santiago Saavedra _______________________________________________ bug-auctex mailing list [email protected] https://lists.gnu.org/mailman/listinfo/bug-auctex
