Hi again,

A couple of replies to points I missed:

On 22/11/2025, Paul D. Nelson wrote:
>> +                                  ;; Restore point to current one before
>> +                                  ;; placing preview
>> +                                  (goto-char point-current)
> Is there a new reason for adding this goto-char?

Absolutely. `preview-place-preview` calls the 'place' function. This
sets the preview properties and could show the buframe if the cursor is
on top of the overlay. Before, this wasn't possible because the point
was always set to be on top of the overlay when the preview is placed
and there's no way for preview-toggle to know the real cursor position.

>> +                (eq (overlay-buffer ov) (window-buffer))
> Consider: (current-buffer)
I use window-buffer because this function is sometimes called from
within a `with-current-buffer` so (current-buffer) is bogus for purposes
of determining if the currently displayed buffer is the same as the
overlay-buffer. Although, I am realizing this could be unnecessary, so
I'll check it.

-- Al



_______________________________________________
bug-auctex mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-auctex

Reply via email to