On 03/07/2012 10:32 AM, Peter O'Gorman wrote: > > I'd like confirmation from Martin that this is the issue first :-)
Actually, I reproduced the issue on Fedora 16, by doing:
diff --git i/tests/local.at w/tests/local.at
index eb01cc0..2b0d136 100644
--- i/tests/local.at
+++ w/tests/local.at
@@ -50,7 +50,7 @@ AT_CHECK([$at_diff "$1" "$2"])
# otherwise, do nothing.
m4_define([AT_CHECK_SHELL_SYNTAX],
[AT_SKIP_IF([test "$ac_cv_sh_n_works" != yes])
-AT_CHECK([/bin/sh -n $1])])
+AT_CHECK([/bin/ksh -n $1])])
m4_define([AT_CHECK_PERL_SYNTAX],
[AT_CHECK([autom4te_perllibdir=$abs_top_srcdir/lib $PERL -c
"$abs_top_builddir"/bin/$1],
>
> If it is then the patch is trivial:
> - test -n "${.sh.version}" # ksh93; put this last since its syntax
> is dodgy
> + test -n "${ZSH_VERSION+set}" # zsh
I'd rather keep the ksh check (it actually isn't erroring out), so I am
applying this instead:
From 32491fcb90ffa80221b2ec651ac9e4d852cad9ff Mon Sep 17 00:00:00 2001
From: Eric Blake <ebl...@redhat.com>
Date: Wed, 7 Mar 2012 10:40:11 -0700
Subject: [PATCH] tests: ignore ksh -n warnings
Recent ksh is noisy:
$ ksh -nc '``'; echo $?
ksh: warning: line 1: `...` obsolete, use $(...)
0
* tests/local.at (AT_CHECK_SHELL_SYNTAX): Ignore noisy ksh on.
Reported by Martin Zaun.
Signed-off-by: Eric Blake <ebl...@redhat.com>
---
tests/local.at | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/local.at b/tests/local.at
index eb01cc0..66027e8 100644
--- a/tests/local.at
+++ b/tests/local.at
@@ -47,10 +47,11 @@ AT_CHECK([$at_diff "$1" "$2"])
# AT_CHECK_SHELL_SYNTAX(PROGRAM)
# ------------------------------
# If the shell handles `-n' well, use it to check the syntax of PROGRAM;
-# otherwise, do nothing.
+# otherwise, do nothing. ksh93 -n also spits outs loads of warnings
+# about older constructs, but we don't care about the warnings.
m4_define([AT_CHECK_SHELL_SYNTAX],
[AT_SKIP_IF([test "$ac_cv_sh_n_works" != yes])
-AT_CHECK([/bin/sh -n $1])])
+AT_CHECK([/bin/sh -n $1], [], [], [ignore])])
m4_define([AT_CHECK_PERL_SYNTAX],
[AT_CHECK([autom4te_perllibdir=$abs_top_srcdir/lib $PERL -c
"$abs_top_builddir"/bin/$1],
--
1.7.7.6
--
Eric Blake ebl...@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
