Hello Reuben, * Reuben Thomas wrote on Mon, Feb 25, 2008 at 05:40:50PM CET: > I attach a diff against current git. It fixes the following problems:
Thanks for the patch. > 1. The English is a bit ropey in places. > > 2. @file was used once where @emph was needed. > > 3. The point in the itemized list starting "Listing files" is redudant, > it's just a restatement of the previous two points. While I agree that there is partial redundancy here, IMVHO the other items by themselves do not make it clear enough that 'make dist' will complain about missing files. > @@ -9860,24 +9860,18 @@ you remember to @samp{cvs add} it. > @item > Using wildcards makes easy to distribute files by mistake. For There is an 'it' missing before 'easy', no? > instance, some code a developer is experimenting with (a test case, > -say) but that should not be part of the distribution. > +say) that should not be part of the distribution. > [EMAIL PROTECTED] > -Finally it's really hard to @file{forget} adding a file to > [EMAIL PROTECTED], because if you don't add it, it doesn't get > +Finally, it's really hard to @emph{forget} to add a file to > [EMAIL PROTECTED], because if you don't add it it is neither I prefer if that comma remains in there, both because I think it is justified by the grammar, and because otherwise the sentence is more difficult to read. > compiled nor installed, so you can't even test it. > @end itemize Can you be bothered to resubmit the patch with these items and the one Tim found addressed, to the automake-patches list, including a ChangeLog entry? Thanks, Ralf