On 11/24/12 2:32 AM, John E. Malmberg wrote:
> The execute_cmd.c module uses make_command_string() as a parameter to the
> savestring() macro.
>
> This causes the savestring() macro to call that function twice().
Thanks, good catch. I made the same temporary variable fix you did.
> I have not done any timing tests to see how this is impacting performance,
> but it definitely shows up when stepping through commands doing debugging.
>
> This issue was first noticed in bash 1.14.7 and is also seen in the current
> bash 4.2.39.
>
> I have locally patched execute_cmd.c to use an intermediate variable. The
> proper fix should probably be in general.h.
That's tough to do and still keep it in an expression context.
Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU [email protected] http://cnswww.cns.cwru.edu/~chet/
