On Jul 29, 2007, at 3:57 PM, Jo Rhett wrote:
Mark Burgess wrote:Please look again at svn. The message seems incorrect or needsclarification. The changes that were made to popen.c would be the onlypossible way to avoid the problem you mention as far as I can see.I think there is some confusion. The diff I showed was 2.2.1 verses trunk. That statement is the only relevant changed code.
That diff doesn't look like trunk, in my working copy the line `CHILD [fd] = 0' is after the block you are concerned with. Please update your sources (I have r428 currently).
Can you demonstrate the the earlier code did *not* have the behaviour you suggest?Demonstrate how? Let me put it this way -- all of our production systems are using 2.2.1 without any problems. And removing that block also allows the trunk code to function without any problems.
Yes, but 2.2.1 has this same block of code that you are concerned about removing. It's at line 621 in popen.c, and its also an essential piece of code that prevents waiting for pid==0. However, I think I know what the problem is, and that it should be fixed if you are running the latest version of trunk. The code was improved to prevent buffer overflow errors in 415, which introduced a regression---a regression which has since been fixed in trunk (from my July 20th email ``patch [1/6] r415 fix'').
Assuming you still have the error with r428, could you post the relevant debug output?
-- Eric Searcy OSU Open Source Lab
PGP.sig
Description: This is a digitally signed message part
_______________________________________________ Bug-cfengine mailing list [email protected] https://cfengine.org/mailman/listinfo/bug-cfengine
