On Jul 30, 2007, at 5:37 PM, Eric Searcy wrote: > I think you have a typo: > > @@ -342,7 +344,7 @@ > > /* Default */ > default: > - CfLog(cferror,"RemovePackage: Package removal not yet > implemented for this package manager.\n","packages"); > + CfLog(cferror,"RemovePackage: Package removal not yet > implemented for this package manager.\n","p"); > break; > } > > The hanging `p' there doesn't match any of the other code blocks. > Should it be ""?
Nope, good catch. > I'm also curious why you're using string constants for CfLog, when > all the code I've seen uses the OUTPUT buffer instead. Are you > sure this works correctly in all scenarios, or is the OUTPUT step > important? From my reading of the code the OUTPUT step is just so that you can sprintf() variables into the string. When you aren't passing in variables you don't need that step. (someone clue me in if I am wrong) -- Jo Rhett senior geek Silicon Valley Colocation Support Phone: 408-400-0550 _______________________________________________ Bug-cfengine mailing list [email protected] https://cfengine.org/mailman/listinfo/bug-cfengine
