Jonathan, Thank you for your efforts. I will consider these points when I have time. It is not clear to me that these are bugs however more like semantics changes. I don't agree with all of them, but I will reply in due course.
Also, note that when you send code that might be non-trivial, we need you to fill out a contributor's form (see AUTHORS file). M Jonathan Chen wrote: > Attached are patches for various bugs and new features to cfengine. All > patches are against cfengine 3.0.2. > > > [FIX] patch-bsd-df > > space returned from statfs() is in number of blocks, which is not > necessarily 1024 bytes. > > > > [FEATURE] patch-collapse-level > > Extend collapse_destination_dir constraint to allow collapsing of up to an > arbitrary number of directory levels. This is useful if you have organized > files into sets by putting them into different source directories, such as > in the example below: > > body copy_from copy_c1($srcdir) { > source => "$(srcdir"); > collapse_destination_dir => 1; > } > > bundle agent docopy($src, $dst) { > vars: > "dirs" slist => { "$(src)/$(sys.os)", > "$(src)/$(sys.os)-$(sys.arch)", > "$(src)/$(sys.os)-$(sys.release)", > "$(src)/$(sys.os)-$(sys.release)-$(sys.arch)", > "$(src)/.*/.*" }; > files: > "$dst" > copy_from => copy_c1("$(src)"), > depth_search => recurse_pkg_includedirs("inf", "@(dirs)"); > } > > > > [FEATURE] patch-diskfree > > adds diskfree(dir) function to return space available at any location. > > > > [FEATURE] patch-dz-arithmetic > > adds simple arithmetic functions > > > > [FIX] patch-exclude-first > > Fixes the bug where only include_dirs is considered when both include_dirs > and exclude_dirs are specified in a search, by evaluating the exclusion > list first. > > > > [FIX] patch-linkstatus > > Fixes the problem where various link promises are always counted as > repaired. > > > > [FIX] patch-method-nochg > > Fixes the problem where usemethod invocations are counted as extra repaired > promises. > > > > [FIX] patch-moveobstructions-whennofile > > Whether or not a directory is moved aside in file operations should not > depend on the when_no_source attribute. > > > > [FEATURE/FIX] patch-netgroup > > Allow various server controls to match based on netgroup in addition to IP > or hostname. Specify "@netgroup-name" in place of hostnames to do netgroup > matching. > This patch also fixes the lack of hostname based matching on the > trustkeysfrom and dynamicaddresses promises. > > > > [FIX] patch-nodeleteslash > > When verifying soft links, do not attempt to delete the trailing slash from > the current on-disk state if the expected link destination also has a > trailing slash. > > > > [FIX] patch-nodupclass > > Avoid adding duplicate result classes to the global class list. This > prevents /var/cfengine/state/allclasses.txt from exploding in size when you > have lots of result classes. > > > > [FIX] patch-regex-detect > > Improve regex detection in IsRegex() to decrease the chance of false > positives. > > > > [FIX] patch-single-copy > > The files_single_copy list was only being matched quazi-literally, where > the file name was actually being used as a regex and the single copy list > was being matched against that. > > > > > ------------------------------------------------------------------------ > > _______________________________________________ > Bug-cfengine mailing list > Bug-cfengine@cfengine.org > https://cfengine.org/mailman/listinfo/bug-cfengine -- Mark Burgess ------------------------------------------------- Professor of Network and System Administration Oslo University College, Norway Personal Web: http://www.iu.hio.no/~mark Office Telf : +47 22453272 ------------------------------------------------- _______________________________________________ Bug-cfengine mailing list Bug-cfengine@cfengine.org https://cfengine.org/mailman/listinfo/bug-cfengine