On 10/11/05, n0dalus <[EMAIL PROTECTED]> wrote:
> On 10/11/05, Paul Eggert <[EMAIL PROTECTED]> wrote:
> > n0dalus <[EMAIL PROTECTED]> writes:
> >
> > > In this case the mount point it can't access is part of a chroot'ed bind.
> > > In my opinion it should just quietly ignore that mount point.
> >
> > Thanks for reporting this. Does the following patch fix your problem?
> >
> > http://lists.gnu.org/archive/html/bug-coreutils/2005-10/msg00048.html
> >
>
> Hi Paul,
>
> I checked out the CVS version and applied the patch, but I still have
> the problem.
>
> When I run it through gdb, I set breakpoints where ME_DUMMY is used
> (the function defined to check fs type) and it goes through all my
> mount points but the 'me->me_devname' variable never gets set to
> '/var/named/chroot/proc' and it never gets checked.
> It's as though this warning is not output by the program itself, but
> by something else when access to that mount point is attempted.
>
> So unless I've done something wrong I would say this patch doesn't fix
> my problem. If I get some more time I will debug it some more and see
> if I can find the point where the error occurs.
>
> n0dalus.
>
I managed to get the problem fixed by adding 'proc' to the list of
filesystems to mark as dummy. I'm not sure if this is the right thing
to do (do people want to be able to see proc mounts by default?), but
it works for me.
Attached is my updated version of the patch.
n0dalus.
Index: coreutils/lib/mountlist.c
===================================================================
RCS file: /cvsroot/coreutils/coreutils/lib/mountlist.c,v
retrieving revision 1.55
diff -p -d -U6 -r1.55 mountlist.c
--- coreutils/lib/mountlist.c 22 Sep 2005 06:05:39 -0000 1.55
+++ coreutils/lib/mountlist.c 11 Oct 2005 14:34:12 -0000
@@ -140,12 +140,14 @@ char *strstr ();
# define SIZE_MAX ((size_t) -1)
#endif
#ifndef ME_DUMMY
# define ME_DUMMY(Fs_name, Fs_type) \
(strcmp (Fs_type, "autofs") == 0 \
+ || strcmp (Fs_type, "none") == 0 \
+ || strcmp (Fs_type, "proc") == 0 \
|| strcmp (Fs_type, "subfs") == 0 \
/* for Irix 6.5 */ \
|| strcmp (Fs_type, "ignore") == 0)
#endif
#ifndef ME_REMOTE
Index: coreutils/src/df.c
===================================================================
RCS file: /cvsroot/coreutils/coreutils/src/df.c,v
retrieving revision 1.168
diff -p -d -U6 -r1.168 df.c
--- coreutils/src/df.c 16 Aug 2005 20:33:40 -0000 1.168
+++ coreutils/src/df.c 11 Oct 2005 14:34:12 -0000
@@ -719,13 +719,13 @@ or all file systems by default.\n\
\n\
"), stdout);
fputs (_("\
Mandatory arguments to long options are mandatory for short options too.\n\
"), stdout);
fputs (_("\
- -a, --all include file systems having 0 blocks\n\
+ -a, --all include dummy file systems\n\
-B, --block-size=SIZE use SIZE-byte blocks\n\
-h, --human-readable print sizes in human readable format (e.g., 1K 234M 2G)\n\
-H, --si likewise, but use powers of 1000 not 1024\n\
"), stdout);
fputs (_("\
-i, --inodes list inode information instead of block usage\n\
Index: coreutils/NEWS
===================================================================
RCS file: /cvsroot/coreutils/coreutils/NEWS,v
retrieving revision 1.319
diff -p -d -U6 -r1.319 NEWS
--- coreutils/NEWS 1 Oct 2005 09:50:09 -0000 1.319
+++ coreutils/NEWS 11 Oct 2005 14:34:12 -0000
@@ -200,12 +200,14 @@ GNU coreutils NEWS
date, du, ls, and pr's time formats now support new %:z, %::z, %:::z
specifiers for numeric time zone offsets like -07:00, -07:00:00, and -07.
dd has new iflag= and oflag= flags "binary" and "text", which have an
effect only on nonstandard platforms that distinguish text from binary I/O.
+ df now ignores bind mounts by default; use "-a" to not ignore them.
+
du accepts new options: --time[=TYPE] and --time-style=STYLE
join now supports a NUL field separator, e.g., "join -t '\0'".
join now detects and reports incompatible options, e.g., "join -t x -t y",
ls no longer outputs an extra space between the mode and the link count
_______________________________________________
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils
