Jim Meyering <[EMAIL PROTECTED]> wrote:
> I'll use 180.
FYI, here's the patch:
2006-09-26 Jim Meyering <[EMAIL PROTECTED]>
* NEWS: rm works around a bug in Darwin 8.6.1 w/NFS that kept
it from removing a directory containing 188 or more entries.
* src/remove.c (CONSECUTIVE_READDIR_UNLINK_THRESHOLD): Decrease by
20, go work around the buggy readdir on Darwin 8.6.1 with NFS.
Reported by Matthew Woehlke.
Index: NEWS
===================================================================
RCS file: /fetish/cu/NEWS,v
retrieving revision 1.430
diff -u -r1.430 NEWS
--- NEWS 26 Sep 2006 19:11:25 -0000 1.430
+++ NEWS 26 Sep 2006 20:42:01 -0000
@@ -4,6 +4,9 @@
** Improved robustness
+ rm works around a bug in Darwin 8.6.1 w/NFS that kept it from removing
+ a directory containing 188 or more entries.
+
sort would fail to handle very large input (around 40GB) on systems with a
mkstemp function that returns a file descriptor limited to 32-bit offsets.
Index: src/remove.c
===================================================================
RCS file: /fetish/cu/src/remove.c,v
retrieving revision 1.159
diff -u -r1.159 remove.c
--- src/remove.c 11 Sep 2006 13:22:05 -0000 1.159
+++ src/remove.c 26 Sep 2006 20:34:36 -0000
@@ -56,11 +56,12 @@
SunOS's readdir when applied to ufs file systems and Darwin 6.5's
(and OSX v.10.3.8's) HFS+. This maximum is conservative in that
demonstrating the problem seems to require a directory containing
- at least 254 deletable entries (which doesn't count . and ..), so
- we could conceivably increase the maximum value to 254. */
+ at least 254 deletable entries (which doesn't count . and ..).
+ However, in 2006, we see that Darwin 8.6.1, using NFS has an even
+ lower limit: 188. */
enum
{
- CONSECUTIVE_READDIR_UNLINK_THRESHOLD = 200
+ CONSECUTIVE_READDIR_UNLINK_THRESHOLD = 180
};
enum Ternary
_______________________________________________
Bug-coreutils mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-coreutils
