Bruno Haible <[EMAIL PROTECTED]> wrote: > - On MacOS X 10.3.9: > > make check-TESTS > PASS: misc/help-version.log > FAIL: misc/invalid-opt.log ... > FAIL: rm/empty-name.log > PASS: rm/f-1.log ... > FAIL: misc/md5sum.log > FAIL: misc/md5sum-newline.log > =========================================== > 53 of 333 tests failed > (50 tests were not run) ... > FAIL: misc/invalid-opt.log (exit: 2) > ==================================== > > Bareword "File::Temp::cleanup" not allowed while "strict subs" in use at > CuTmpdir.pm line 85. > Compilation failed in require. > Compilation failed in require. > BEGIN failed--compilation aborted. ... > After removing the incriminated line "File::Temp::cleanup":
Thanks for the report! The patch below should fix it, at least with that version of Perl, without penalizing people (who interrupt tests) with newer versions. > All coreutils tests pass, and all gnulib tests pass, except: > - test-getaddrinfo (hung; had to kill it after 14 minutes idle time). Yes, that one is annoying because it represents a guaranteed failure when testing off line. I've been tempted to exclude it before, too... Do you know what it was trying to do when hung? I know it tries to connect to these systems: #define HOST1 "www.gnu.org" #define HOST2 "www.ibm.com" #define HOST3 "microsoft.com" #define HOST4 "google.org" --------------------- >From fc6827e2bb0a8d4d70c7f399e3b2915654a0c926 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTECTED]> Date: Fri, 30 May 2008 09:45:53 +0200 Subject: [PATCH] tests: avoid failure with older version of Perl's File::Temp * tests/CuTmpdir.pm (import): Use &File::Temp::cleanup only if it is defined. Reported by Bruno Haible in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/13652 --- tests/CuTmpdir.pm | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tests/CuTmpdir.pm b/tests/CuTmpdir.pm index e21306a..a7dd8b6 100644 --- a/tests/CuTmpdir.pm +++ b/tests/CuTmpdir.pm @@ -82,7 +82,9 @@ sub import { if ($$ == $original_pid and defined $dir) { chmod_tree; - File::Temp::cleanup; + # Older versions of File::Temp lack this method. + exists &File::Temp::cleanup + and &File::Temp::cleanup; } $SIG{$sig} = 'DEFAULT'; kill $sig, $$; -- 1.5.6.rc0.30.g51263 _______________________________________________ Bug-coreutils mailing list [email protected] http://lists.gnu.org/mailman/listinfo/bug-coreutils
