* tests/CuTmpdir.pm (chmod_tree): Do not run chmod on undefined argument, can happen when the build path contains spaces. ---
Hi Jim, this fixes a regression of "make check" when source and build tree live in a directory with spaces in the name. The regression was introduced some time after I posted a fix for the issue last time. Cheers, Ralf =========================================== 1 of 347 tests failed (96 tests were not run) See tests/test-suite.log Please report it to bug-coreutils@gnu.org =========================================== ======================================================== GNU coreutils 6.12.100-ecb0e: tests/test-suite.log ======================================================== 1 of 347 tests failed. (96 tests were not run). .. contents:: :depth: 2 FAIL: rm/fail-eperm.log (exit: 255) =================================== ./../../coreutils/tests/rm/fail-eperm: skipping test: unsafe working directory name: `/home/test/coreutils/new dir with spaces/build/tests/fail-eperm' Use of uninitialized value in chdir at ../../coreutils/tests/CuTmpdir.pm line 48. Use of chdir('') or chdir(undef) as chdir() is deprecated at ../../coreutils/tests/CuTmpdir.pm line 48. Insecure dependency in chdir while running with -T switch at ../../coreutils/tests/CuTmpdir.pm line 48. END failed--call queue aborted. make[4]: *** [test-suite.log] Error 1 make[4]: Leaving directory `/home/test/coreutils/new dir with spaces/build/tests' tests/CuTmpdir.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/CuTmpdir.pm b/tests/CuTmpdir.pm index a7dd8b6..166e50b 100644 --- a/tests/CuTmpdir.pm +++ b/tests/CuTmpdir.pm @@ -45,7 +45,7 @@ sub chmod_1 sub chmod_tree { - if (chdir $dir) + if (defined $dir && chdir $dir) { # Perform the equivalent of find . -type d -print0|xargs -0 chmod -R 700. my $options = {untaint => 1, wanted => \&chmod_1}; -- 1.5.5.40.g4cdda _______________________________________________ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils