> Jim Meyering <jim <at> meyering.net> writes: > Sorry for not adjusting the hash myself. > Filtering out the copyright year is a good change. > >> NEWS_hash = \ >> $$(sed -n '/^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)/,$$p' \ >> - $(srcdir)/NEWS | md5sum -) >> + $(srcdir)/NEWS | grep -v '^Copyright .*Free Software' | md5sum -) > > Is it worth saving a process here, by folding the grep -v into the sed? > > NEWS_hash = \ > $$(sed -n 's/^Copyright .*Free Software.*//; \ > /^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)/,$$p' \ > $(srcdir)/NEWS | md5sum -)
Not for that reason, but now that I see your all-sed solution, how about *not* excluding the Copyright line, but merely year numbers? Then, an improbable accident that simply removed the line would not get by the check. _______________________________________________ Bug-coreutils mailing list [email protected] http://lists.gnu.org/mailman/listinfo/bug-coreutils
