Eric Blake wrote: > According to Jim Meyering on 3/20/2009 12:34 AM: >> I like it. Thanks. >> However, I'd like to keep O_FULLBLOCK as a single-bit value. >> That's slightly less surprising, and makes the change a tad >> smaller. How about this? > > Fair enough; I debated about doing it myself. Plus, it makes it easier to > add future extensions, should the need arise:
... I've just pushed that, along with this follow-up to make "make syntax-check" work: >From 143bfd67c97f255cdfcc629161cf5a2bc343aa65 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Fri, 20 Mar 2009 15:20:09 +0100 Subject: [PATCH] tests: teach sc_dd_O_FLAGS about new syntax in dd.c * cfg.mk (sc_dd_O_FLAGS): Adapt to new syntax. --- cfg.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cfg.mk b/cfg.mk index e220572..c6b6e9b 100644 --- a/cfg.mk +++ b/cfg.mk @@ -51,7 +51,7 @@ old_NEWS_hash = fa6cba1740b3f385520c1b54d90859ca - dd = $(srcdir)/src/dd.c sc_dd_O_FLAGS: @rm -f [email protected] [email protected] - @{ echo O_FULLBLOCK; perl -nle '/MAX \((O_\w*),/ and print $$1' \ + @{ echo O_FULLBLOCK; perl -nle '/^ +\| (O_\w*)$$/ and print $$1' \ $(dd); } | sort > [email protected] @{ echo O_NOFOLLOW; perl -nle '/{"[a-z]+",\s*(O_\w+)},/ and print $$1' \ $(dd); } | sort > [email protected] -- 1.6.2.rc1.285.gc5f54 _______________________________________________ Bug-coreutils mailing list [email protected] http://lists.gnu.org/mailman/listinfo/bug-coreutils
