Giuseppe Scrivano wrote:
> diff --git a/src/chroot.c b/src/chroot.c
> +
> +#ifndef GID_T_MAX
> +# define GID_T_MAX TYPE_MAXIMUM (gid_t)
> +#endif
The above is redundant and already done in system.h
> +
> +#ifndef MAXGID
> +# define MAXGID GID_T_MAX
> +#endif
Why add the new MAXGID name?
> + if (userspec)
> + {
> + uid_t uid;
> + gid_t gid;
> + char *user;
> + char *group;
> + const char *err = parse_user_spec (userspec, &uid, &gid, &user,
> &group);
> + if (err)
> + {
> + perror (err);
> + exit (1);
> + }
Probably should use error(EXIT_FAILURE, ...) instead of perror();
cheers,
Pádraig.
_______________________________________________
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils
