Pádraig Brady wrote:
> The rest of your comments were hopefully fixed also in the latest version:
>
> http://www.pixelbeat.org/patches/stdbuf.diff
Looks good.
A few suggested documentation changes,
and syntax in tests: please put a space before the trailing "&"
operator:
$ g grep '[^ &]&$'
tests/dd/reblock:dd ibs=3 obs=3 if=dd.fifo > out 2> err&
tests/dd/reblock:dd bs=3 ibs=1 obs=1 if=dd.fifo > out 2> err&
tests/misc/cat-buf:dd count=1 if=fifo > out 2> err&
tests/misc/stdbuf:dd count=1 if=fifo > out 2> err&
tests/misc/stdbuf:dd count=1 if=fifo > out 2> err&
tests/misc/stdbuf: # dd count=1 if=fifo > /dev/null 2> err&
tests/misc/stdbuf: # dd count=1 if=fifo > out 2> err&
diff --git a/doc/coreutils.texi b/doc/coreutils.texi
index 764f02c..7a857e0 100644
--- a/doc/coreutils.texi
+++ b/doc/coreutils.texi
@@ -14511,8 +14511,8 @@ stdbuf invocation
@cindex standard streams, buffering
@cindex line buffered
-...@command{stdbuf} allows one modify the buffering operations of the
-3 standard I/O streams associated with a program. Synopsis:
+...@command{stdbuf} allows one to modify the buffering operations of the
+three standard I/O streams associated with a program. Synopsis:
@example
stdbuf @var{opti...@dots{} @var{command}
@@ -14529,19 +14529,19 @@ stdbuf invocation
@itemx --inp...@var{mode}
@opindex -i
@opindex --input
-Setup the standard input stream buffering.
+Adjust the standard input stream buffering.
@item -o @var{mode}
@itemx --outp...@var{mode}
@opindex -o
@opindex --output
-Setup the standard output stream buffering.
+Adjust the standard output stream buffering.
@item -e @var{mode}
@itemx --err...@var{mode}
@opindex -e
@opindex --error
-Setup the standard error stream buffering.
+Adjust the standard error stream buffering.
@end table
@@ -14556,7 +14556,7 @@ stdbuf invocation
This option is invalid with standard input.
@item 0
-Set the stream to unbuffered mode.
+Disable buffering of the selected stream.
In this mode data is output immediately and only the
amount of data requested is read from input.
Also, this paragraph is ambiguous.
Can you clarify it?
NOTE: If @var{command} controls the buffering of its standard streams
(like @command{tee}) then this will override corresponding settings changed
by this command. Also some filters (like @command{dd} and @command{cat} etc.)
don't use streams for I/O, and are thus unaffected.
Then you're welcome to push.
Thanks for doing all this!
_______________________________________________
Bug-coreutils mailing list
Bug-coreutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-coreutils
