Pádraig Brady wrote:
> Voelker, Bernhard wrote:
>> Pádraig wrote:
>>> Yep I think so. Moving just the install_signal_handlers() to the top,
>>
>> can we expect this to happen in one of the next releases?
>>
>>> p.s. I'm still unsure as to why open(O_TRUNC) takes "a while".
>>> Perhaps there is a trunc=paranoid mount option I'm unaware of
>>> that actually writes zeros when truncating a file.
>>
>> I guess this depends on the filesystem type. E.g. on another Solaris10
>> box with UFS `dd if=/dev/zero of=$HOME/x bs=1G count=10` takes
>> a rather good ~1.5min while the subsequent open(O_TRUNC) then
>> takes ~6sec. I don't think zeroes are written there ;-)
>
> Thanks for the clarification.
> I guess the file systems need time to deallocate all the blocks.
> Right so the attached seems to address the issue and
> passes all tests. I don't see much problem with adding
> this to the release we're trying to complete this week.

Thanks for doing that.
I agree that is seems safe, so please push it.


Reply via email to