Pádraig Brady wrote: > Jim Meyering wrote: >> Pádraig Brady wrote: >>> Jim Meyering wrote: >>>> If anyone knows of bug-related fixes that aren't yet applied, >>>> please speak up. I'm thinking of making a snapshot today, >>>> leading to a bug-fix release, coreutils-7.6, next week. >>> It would be nice to get Ondřej's fix for copy xattrs from readonly files. >>> I might be able to look at that in a couple of hours. >> >> Thanks! >> >>> There's also this one that popped up in our recent favorite: tail-2/wait >> >> Right. I suppose it'd be best to add some distcheck-time >> code to prevent this sort of regression: configure as if >> inotify were not available, and ensure the tail-related tests still pass. >> >> Or maybe even add a hidden (three hyphen ---no-inotify, since we presume >> it'll be used only for testing) option to expose that behavior without >> the requirement to jump through build-time hoops. >> >> What do you think? > > I like the ---no-inotify option since the inotify support check is at > runtime anyway. How about the attached.
What service! ;-) worth considering: ---disable-inotify ? either way is fine with me. Please adjust the tests not to use double quotes on the first value, and to use single quotes on the empty string: i.e., change this > +for inotify in "---no-inotify" ""; do to this: for inotify in ---no-inotify ''; do Thanks! >>From d168f1aabcff0f6bd79ce84864a76b052904baa5 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?P=C3=A1draig=20Brady?= <[email protected]> > Date: Fri, 4 Sep 2009 21:41:30 +0100 > Subject: [PATCH] tests: test old tail -f method even on systems with inotify > > * src/tail.c (main): Add an undocumented ---no-inotify option > to allow disabling inotify. > * tests/tail-2/pid: Run test in both normal and "no_inotify" modes. > * tests/tail-2/tail-n0f: Likewise. > * tests/tail-2/wait: Likewise. > * tests/tail-2/append-only: Likewise. > --- > src/tail.c | 29 ++++++++++++++----- > tests/tail-2/append-only | 9 ++++-- > tests/tail-2/pid | 46 ++++++++++++++++--------------- > tests/tail-2/tail-n0f | 24 +++++++++------- > tests/tail-2/wait | 67 ++++++++++++++++++++++++---------------------
