Eric Blake wrote:
> OK to commit?  We build lib using gcc warnings, but not gnulib-tests; it is
> nicer to treat all gnulib files equally.  Right now, many of the gnulib tests
> are quite noisy with coreutils' set of warnings, that will involve a series of
> patches to gnulib to clean up.
>
> Meanwhile, I was seeing multiple instances of warnings like this when using
> cygwin's gcc 4.3.4:
>
>   CC       mbswidth.o
> cc1: warning: -funit-at-a-time is required for inlining of functions that are
> only called once [-Wdisabled-optimization]
...
> Subject: [PATCH] maint: turn on compiler warnings for gnulib tests
>
> * gnulib-tests/Makefile.am (AM_CFLAGS): Add WARN_CFLAGS.
> * configure.ac (enable-gcc-warnings): Also use -funit-at-a-time,
> to silence gcc 4.3.4 -Wdisabled-optimization.
> * .gitignore: Ignore some more files.

Good idea.  Please do.
Thanks.


Reply via email to