Eric Blake wrote: > [moving to bug-coreutils] > > According to Eric Blake on 10/30/2009 5:51 AM: >> Actually, I thought of one other solution, after sleeping on the problem. >> Any client (like coreutils) that wants to continue using gnulib-tool >> --avoid=canonicalize-lgpl merely needs to also provide a gnulib override >> for modules/rename-tests.diff that re-adds the @LIBINTL@ designation to >> LDADD for that test to resume linking on cygwin 1.5. I'll post a patch to >> coreutils soon. > > With this patch, and a bump to the latest gnulib[*], I can (once again) > compile coreutils on cygwin 1.5 with --enable-gcc-warnings. Does it look > okay to commit, once gnulib falls into place?
This looks fine. Test writers will thank you. Push at will. > [*] Well, technically, this patch assumed that my proposed patch for > vasnprintf variable shadowing will be picked up; I'm still waiting for > Bruno on that one. ... > Subject: [PATCH] build: avoid some warnings > > * gl/lib/mbsalign.c (mbsalign): Mark unused parameter. > * bootstrap.conf (gnulib_modules): Remove obsolete > rename-dest-slash. > * gnulib-tests/Makefile.am (AM_CFLAGS): Reduce set of warnings for > gnulib tests. > * gl/modules/rename-tests.diff (Makefile.am): New file, to add > LIBINTL to LDADD, since we avoid canonicalize-lgpl module. > * gl/lib/regcomp.c.diff (regerror, calc_next) > (build_collating_symbol, parse_bracket_element, build_equiv_class) > (free_tree): Mark unused parameters. > * gl/lib/regex_internal.h.diff (re_string_elem_size_at): New file, > to mark unused parameters. > * .gitignore: Ignore temporary build artifacts.
