On 10/01/10 00:09, Chen Guo wrote:
Hi Padraig,I went ahead and corrected the errors you caught, as well as moved over eol_parse() to gl/lib/unescape.c. Calls from ptx, pr, and printf, as you said, probably should be in a separate patch. Also I noticed gl/lib/randperm.h didn't have the GPL disclaimer thing at the beginning. I though it might've been b/c of the small size, but mbsalign.h also had it, so I went ahead and added the disclaimer. I'm guessing this is also by Prof. Eggert, but it seems convention is to only declare authorship in the .c files, so I left that out.
Thanks for the update Chen. I'll review this hopefully early next week. cheers, Pádraig.
