On 16/03/10 07:28, Jim Meyering wrote:
>
> These look like fine improvements.
> Have you considered dividing it into two or more change sets?
> Mixing "fix" and "clean-up" changes in one change-set is
> best avoided, if only to ease review and bisection.
Sure. I'll split out the fix which is triggered when
one has \t characters in combination with multi byte chars
in an oversized field:
> In addition, it would ease long-term maintenance if you would
> at least outline how to exercise the bug(s?) you're fixing.
> Then I'll try to make time to write a test for it.
char* str = ambsalign("t\tést", 4, MBS_ALIGN_LEFT, 0);
puts(str);
free(str);
cheers,
Pádraig.
